Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize cars before restore #846

Merged
merged 5 commits into from Jul 25, 2023
Merged

Initialize cars before restore #846

merged 5 commits into from Jul 25, 2023

Conversation

cesarBLG
Copy link
Contributor

@cesarBLG cesarBLG added bug Something isn't working not-for-unstable Special label to exclude a pull request from the Unstable Version labels Jun 22, 2023
@cesarBLG cesarBLG self-assigned this Jun 22, 2023
@cesarBLG cesarBLG removed the not-for-unstable Special label to exclude a pull request from the Unstable Version label Jun 23, 2023
twpol pushed a commit that referenced this pull request Jun 29, 2023
@openrails-bot
Automatic merge of T1.5.1-485-g7772f5814 and 9 pull requests
b06654f 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #842 at a1c784c: Set up ability for steam locomotives to have multiple engines
- Pull request #846 at 1748e36: Initialize cars before restore
- Pull request #847 at 51067c3: Add additional default brakeshoe CoF
twpol pushed a commit that referenced this pull request Jul 1, 2023
@openrails-bot
Automatic merge of T1.5.1-492-g2232f9c75 and 9 pull requests
b5fbe20 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #842 at a1c784c: Set up ability for steam locomotives to have multiple engines
- Pull request #846 at 1748e36: Initialize cars before restore
- Pull request #847 at 51067c3: Add additional default brakeshoe CoF
twpol pushed a commit that referenced this pull request Jul 1, 2023
@openrails-bot
Automatic merge of T1.5.1-492-g2232f9c75 and 10 pull requests
b53fbd3 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #842 at a1c784c: Set up ability for steam locomotives to have multiple engines
- Pull request #846 at 1748e36: Initialize cars before restore
- Pull request #847 at 51067c3: Add additional default brakeshoe CoF
- Pull request #849 at 0d4e3da: Contributed projects and forking clarity
twpol pushed a commit that referenced this pull request Jul 1, 2023
@openrails-bot
Automatic merge of T1.5.1-492-g2232f9c75 and 11 pull requests
a86baa4 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #842 at a1c784c: Set up ability for steam locomotives to have multiple engines
- Pull request #846 at 1748e36: Initialize cars before restore
- Pull request #847 at 51067c3: Add additional default brakeshoe CoF
- Pull request #849 at 0d4e3da: Contributed projects and forking clarity
- Pull request #850 at 1605667: Correct output of sound system info
twpol pushed a commit that referenced this pull request Jul 2, 2023
@openrails-bot
Automatic merge of T1.5.1-492-g2232f9c75 and 11 pull requests
2ae1346 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #831 at 9417e1b: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #846 at 1748e36: Initialize cars before restore
- Pull request #847 at 51067c3: Add additional default brakeshoe CoF
- Pull request #849 at 0d4e3da: Contributed projects and forking clarity
- Pull request #850 at 1605667: Correct output of sound system info
twpol pushed a commit that referenced this pull request Jul 4, 2023
@openrails-bot
Automatic merge of T1.5.1-495-g55f992dcd and 10 pull requests
77c8ab3 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #831 at 9417e1b: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #846 at 9668051: Initialize cars before restore
- Pull request #849 at 0d4e3da: Contributed projects and forking clarity
- Pull request #850 at 1605667: Correct output of sound system info
twpol pushed a commit that referenced this pull request Jul 5, 2023
@openrails-bot
Automatic merge of T1.5.1-495-g55f992dcd and 10 pull requests
47885f8 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at d9d75f4: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #831 at 9417e1b: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #846 at 98f1c45: Initialize cars before restore
- Pull request #849 at 0d4e3da: Contributed projects and forking clarity
- Pull request #850 at 1605667: Correct output of sound system info
@cesarBLG cesarBLG marked this pull request as ready for review July 5, 2023 10:22
twpol pushed a commit that referenced this pull request Jul 6, 2023
@openrails-bot
Automatic merge of T1.5.1-495-g55f992dcd and 10 pull requests
8b5298b 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #831 at 9417e1b: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #846 at 98f1c45: Initialize cars before restore
- Pull request #849 at 0d4e3da: Contributed projects and forking clarity
- Pull request #850 at 1605667: Correct output of sound system info
twpol pushed a commit that referenced this pull request Jul 7, 2023
@openrails-bot
Automatic merge of T1.5.1-495-g55f992dcd and 11 pull requests
e16930c 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves
- Pull request #831 at 19dc744: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #842 at abe7adf: Set up ability for steam locomotives to have multiple engines
- Pull request #846 at 98f1c45: Initialize cars before restore
- Pull request #849 at 0d4e3da: Contributed projects and forking clarity
- Pull request #850 at 1605667: Correct output of sound system info
@cesarBLG cesarBLG requested a review from Csantucci July 7, 2023 08:42
twpol pushed a commit that referenced this pull request Jul 11, 2023
@openrails-bot
Automatic merge of T1.5.1-500-gd06a7b66e and 11 pull requests
3c9f792 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 19dc744: poor mans switch panel on tablet
- Pull request #833 at 50e8499: Implement brake relay valve
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #846 at 98f1c45: Initialize cars before restore
- Pull request #849 at 0d4e3da: Contributed projects and forking clarity
- Pull request #850 at 1605667: Correct output of sound system info
- Pull request #852 at d599941: Remove unneeded adhesion options
twpol pushed a commit that referenced this pull request Jul 13, 2023
@openrails-bot
Automatic merge of T1.5.1-507-gebafd5dad and 10 pull requests
f52d755 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #846 at 98f1c45: Initialize cars before restore
- Pull request #849 at 0d4e3da: Contributed projects and forking clarity
- Pull request #850 at 1605667: Correct output of sound system info
- Pull request #852 at d599941: Remove unneeded adhesion options
twpol pushed a commit that referenced this pull request Jul 13, 2023
@openrails-bot
Automatic merge of T1.5.1-507-gebafd5dad and 11 pull requests
82ba528 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #846 at 98f1c45: Initialize cars before restore
- Pull request #849 at 0d4e3da: Contributed projects and forking clarity
- Pull request #850 at 1605667: Correct output of sound system info
- Pull request #851 at cf9f306: New Triple Valve Features
- Pull request #852 at d599941: Remove unneeded adhesion options
twpol pushed a commit that referenced this pull request Jul 14, 2023
@openrails-bot
Automatic merge of T1.5.1-507-gebafd5dad and 11 pull requests
dc2acec 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #846 at 98f1c45: Initialize cars before restore
- Pull request #849 at 0d4e3da: Contributed projects and forking clarity
- Pull request #850 at 1605667: Correct output of sound system info
- Pull request #851 at cf9f306: New Triple Valve Features
- Pull request #852 at 72b9655: Remove unneeded adhesion options
twpol pushed a commit that referenced this pull request Jul 14, 2023
@openrails-bot
Automatic merge of T1.5.1-507-gebafd5dad and 12 pull requests
fdd824b 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 1bdb7df: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #846 at 98f1c45: Initialize cars before restore
- Pull request #849 at 0d4e3da: Contributed projects and forking clarity
- Pull request #850 at 1605667: Correct output of sound system info
- Pull request #851 at cf9f306: New Triple Valve Features
- Pull request #852 at 72b9655: Remove unneeded adhesion options
Csantucci
Csantucci reviewed Jul 14, 2023
View reviewed changes
Copy link
Contributor

@Csantucci Csantucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With some delay, I have now started reviewing.
I see you have removed some saves and restores related to Script names. In fact I don't understand why these lines were there. Can you describe your thoughts about these lines?
I see that in DieselEngine.cs, method InitializeMoving, RealRPM is set equal to IdleRPM. While I see that this was so also before your changes, I wonder if RealRPM could be set in a way proportional to Throttle value at game start (plus IdleRPM as offset).

twpol pushed a commit that referenced this pull request Jul 15, 2023
@openrails-bot
Automatic merge of T1.5.1-507-gebafd5dad and 12 pull requests
c88f61a 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 1bdb7df: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #846 at 98f1c45: Initialize cars before restore
- Pull request #849 at 0d4e3da: Contributed projects and forking clarity
- Pull request #850 at 1605667: Correct output of sound system info
- Pull request #851 at 858fa7e: New Triple Valve Features
- Pull request #852 at 72b9655: Remove unneeded adhesion options
twpol pushed a commit that referenced this pull request Jul 17, 2023
@openrails-bot
Automatic merge of T1.5.1-507-gebafd5dad and 12 pull requests
2c668f9 
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 1bdb7df: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #846 at 98f1c45: Initialize cars before restore
- Pull request #849 at 0d4e3da: Contributed projects and forking clarity
- Pull request #850 at 1605667: Correct output of sound system info
- Pull request #851 at d3e8c3e: New Triple Valve Features
- Pull request #852 at 72b9655: Remove unneeded adhesion options
@cesarBLG
Copy link
Contributor Author

cesarBLG commented Jul 17, 2023 •
edited

I see you have removed some saves and restores related to Script names. In fact I don't understand why these lines were there. Can you describe your thoughts about these lines?

Probably a mistake. I've reviewed some PRs where unneeded things are saved/restored. Since they do no harm (they are useless), it is very easy to add them while trying to fix a restore bug, without noticing that they are not needed.

I see that in DieselEngine.cs, method InitializeMoving, RealRPM is set equal to IdleRPM. While I see that this was so also before your changes, I wonder if RealRPM could be set in a way proportional to Throttle value at game start (plus IdleRPM as offset).

You may be right. Is there any situation where throttle at game start is not 0 (except after a restore)?

Edit: I see that InitializeMoving() in Train.cs adjusts the initial throttle setting, so you are right. RPM should be determined from the Throttle-RPM table.

twpol pushed a commit that referenced this pull request Jul 18, 2023
@openrails-bot
Automatic merge of T1.5.1-507-gebafd5dad and 12 pull requests
7345d63 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 1bdb7df: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #844 at 3f42c30: Animate axles separately
- Pull request #846 at 98f1c45: Initialize cars before restore
- Pull request #849 at 0d4e3da: Contributed projects and forking clarity
- Pull request #850 at 1605667: Correct output of sound system info
- Pull request #851 at d3e8c3e: New Triple Valve Features
- Pull request #852 at 72b9655: Remove unneeded adhesion options
twpol pushed a commit that referenced this pull request Jul 19, 2023
@openrails-bot
Automatic merge of T1.5.1-507-gebafd5dad and 13 pull requests
071564e 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 1bdb7df: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #844 at 3f42c30: Animate axles separately
- Pull request #846 at 98f1c45: Initialize cars before restore
- Pull request #849 at 0d4e3da: Contributed projects and forking clarity
- Pull request #850 at 1605667: Correct output of sound system info
- Pull request #851 at d3e8c3e: New Triple Valve Features
- Pull request #852 at 72b9655: Remove unneeded adhesion options
- Pull request #853 at c8f02ad: Notify out of focus
twpol pushed a commit that referenced this pull request Jul 21, 2023
@openrails-bot
Automatic merge of T1.5.1-507-gebafd5dad and 14 pull requests
bfb6163 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 1bdb7df: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #844 at 3f42c30: Animate axles separately
- Pull request #846 at 98f1c45: Initialize cars before restore
- Pull request #849 at 0d4e3da: Contributed projects and forking clarity
- Pull request #850 at 1605667: Correct output of sound system info
- Pull request #851 at d3e8c3e: New Triple Valve Features
- Pull request #852 at 72b9655: Remove unneeded adhesion options
- Pull request #853 at c8f02ad: Notify out of focus
- Pull request #854 at 027fac8: fix: Updating manual to match PR 647
twpol pushed a commit that referenced this pull request Jul 22, 2023
@openrails-bot
Automatic merge of T1.5.1-515-g868d5abc9 and 11 pull requests
9cc2394 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #844 at 3f42c30: Animate axles separately
- Pull request #846 at 98f1c45: Initialize cars before restore
- Pull request #851 at d3e8c3e: New Triple Valve Features
- Pull request #853 at c8f02ad: Notify out of focus
- Pull request #854 at 027fac8: fix: Updating manual to match PR 647
@Csantucci @cesarBLG
Update Source/Orts.Simulation/Simulation/RollingStocks/SubSystems/Pow…
eae6246 
…erSupplies/DieselEngine.cs


I have also tested it, and it works

Co-authored-by: César Benito Lamata <cesarbema2009@hotmail.com>
Csantucci
Csantucci approved these changes Jul 23, 2023
View reviewed changes
Copy link
Contributor

@Csantucci Csantucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is OK to me now.

twpol pushed a commit that referenced this pull request Jul 23, 2023
@openrails-bot
Automatic merge of T1.5.1-515-g868d5abc9 and 11 pull requests
125ab67 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #844 at 3f42c30: Animate axles separately
- Pull request #846 at eae6246: Initialize cars before restore
- Pull request #851 at d3e8c3e: New Triple Valve Features
- Pull request #853 at c8f02ad: Notify out of focus
- Pull request #854 at 027fac8: fix: Updating manual to match PR 647
twpol pushed a commit that referenced this pull request Jul 23, 2023
@openrails-bot
Automatic merge of T1.5.1-515-g868d5abc9 and 11 pull requests
5c30079 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #844 at 3f42c30: Animate axles separately
- Pull request #846 at eae6246: Initialize cars before restore
- Pull request #851 at d3e8c3e: New Triple Valve Features
- Pull request #853 at 8357922: Notify out of focus
- Pull request #854 at 027fac8: fix: Updating manual to match PR 647
@cesarBLG
Copy link
Contributor Author

Thanks, Carlo

twpol pushed a commit that referenced this pull request Jul 23, 2023
@openrails-bot
Automatic merge of T1.5.1-515-g868d5abc9 and 11 pull requests
e01554d 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #844 at 3f42c30: Animate axles separately
- Pull request #846 at eae6246: Initialize cars before restore
- Pull request #851 at f4feee3: New Triple Valve Features
- Pull request #853 at 8357922: Notify out of focus
- Pull request #854 at 027fac8: fix: Updating manual to match PR 647
twpol pushed a commit that referenced this pull request Jul 24, 2023
@openrails-bot
Automatic merge of T1.5.1-525-gfc86323b8 and 10 pull requests
341105a 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #844 at 3f42c30: Animate axles separately
- Pull request #846 at eae6246: Initialize cars before restore
- Pull request #853 at 8357922: Notify out of focus
- Pull request #854 at 027fac8: fix: Updating manual to match PR 647
twpol pushed a commit that referenced this pull request Jul 25, 2023
@openrails-bot
Automatic merge of T1.5.1-525-gfc86323b8 and 11 pull requests
e8662e4 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #844 at 3f42c30: Animate axles separately
- Pull request #846 at eae6246: Initialize cars before restore
- Pull request #853 at 8357922: Notify out of focus
- Pull request #854 at 027fac8: fix: Updating manual to match PR 647
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
twpol pushed a commit that referenced this pull request Jul 25, 2023
@openrails-bot
Automatic merge of T1.5.1-529-gded0036a4 and 9 pull requests
02707bc 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #799 at dc03850: Consolidated wind simulation
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #846 at eae6246: Initialize cars before restore
- Pull request #853 at 8357922: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
@cesarBLG cesarBLG merged commit 2f57132 into openrails:master Jul 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Csantucci Csantucci Csantucci approved these changes

Assignees

@cesarBLG cesarBLG

Labels
bug Something isn't working
Milestone
No milestone
2 participants
@cesarBLG @Csantucci