Add additional default brakeshoe CoF #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesarBLG
reviewed
Jun 26, 2023
| k4 = 39.5f; | ||
| k5 = 33f; | ||
|
|
||
| frictionfraction = k1 * ((brakeShoeForcekN + k2) / (brakeShoeForcekN + k3)) * ((MpS.ToKpH(AbsSpeedMpS) + k4) / (MpS.ToKpH(AbsSpeedMpS) + k5)); |
There was a problem hiding this comment.
You are using the same formula in several places. Consider moving it outside the if blocks to avoid code duplication
twpol
pushed a commit
that referenced
this pull request
Jun 29, 2023
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting - Pull request #757 at d9d75f4: Unify RailDriver code implementations - Pull request #799 at dc03850: Consolidated wind simulation - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #842 at a1c784c: Set up ability for steam locomotives to have multiple engines - Pull request #846 at 1748e36: Initialize cars before restore - Pull request #847 at 51067c3: Add additional default brakeshoe CoF
twpol
pushed a commit
that referenced
this pull request
Jul 1, 2023
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting - Pull request #757 at d9d75f4: Unify RailDriver code implementations - Pull request #799 at dc03850: Consolidated wind simulation - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #842 at a1c784c: Set up ability for steam locomotives to have multiple engines - Pull request #846 at 1748e36: Initialize cars before restore - Pull request #847 at 51067c3: Add additional default brakeshoe CoF
twpol
pushed a commit
that referenced
this pull request
Jul 1, 2023
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting - Pull request #757 at d9d75f4: Unify RailDriver code implementations - Pull request #799 at dc03850: Consolidated wind simulation - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #842 at a1c784c: Set up ability for steam locomotives to have multiple engines - Pull request #846 at 1748e36: Initialize cars before restore - Pull request #847 at 51067c3: Add additional default brakeshoe CoF - Pull request #849 at 0d4e3da: Contributed projects and forking clarity
twpol
pushed a commit
that referenced
this pull request
Jul 1, 2023
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting - Pull request #757 at d9d75f4: Unify RailDriver code implementations - Pull request #799 at dc03850: Consolidated wind simulation - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #842 at a1c784c: Set up ability for steam locomotives to have multiple engines - Pull request #846 at 1748e36: Initialize cars before restore - Pull request #847 at 51067c3: Add additional default brakeshoe CoF - Pull request #849 at 0d4e3da: Contributed projects and forking clarity - Pull request #850 at 1605667: Correct output of sound system info
twpol
pushed a commit
that referenced
this pull request
Jul 2, 2023
- Pull request #570 at 7269d24: Experimental glTF 2.0 support with PBR lighting - Pull request #757 at d9d75f4: Unify RailDriver code implementations - Pull request #799 at dc03850: Consolidated wind simulation - Pull request #821 at cc3af66: Adds suppression of safety valves - Pull request #829 at 434af02: Improvements for air brakes #3 - Emergency valves - Pull request #831 at 9417e1b: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #846 at 1748e36: Initialize cars before restore - Pull request #847 at 51067c3: Add additional default brakeshoe CoF - Pull request #849 at 0d4e3da: Contributed projects and forking clarity - Pull request #850 at 1605667: Correct output of sound system info
|
Hi Cesar, Thanks for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following some research some additional CoF curves have been found for brake shoe operation.
These have been added to increase the variety available to users.
These changes are an enhancement as part of - https://blueprints.launchpad.net/or/+spec/braking-enhancement