Fix Retainer State Disappearing from HUD on Restore #872
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twpol
pushed a commit
that referenced
this pull request
Sep 10, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #831 at 594df54: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at d05f581: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #857 at 9afc8c3: Adding Air Flow Meters - Pull request #863 at a34b857: Alternate preset 3D cabviewpoints - Pull request #864 at e71bc5a: Fixes for Undesired Emergency Applications - Pull request #865 at 776d6df: Dispatcher window improvements - Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars - Pull request #870 at 5cb32fa: Fix water restore - Pull request #871 at c2388e6: Signal aspects are multiplied when reopening Dispatcher Window - Pull request #872 at 00c5b8b: Fix Retainer State Disappearing from HUD on Restore
cesarBLG
approved these changes
Sep 10, 2023
twpol
pushed a commit
that referenced
this pull request
Sep 10, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations - Pull request #831 at 3e672a8: poor mans switch panel on tablet - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows - Pull request #853 at d05f581: Notify out of focus - Pull request #855 at b39e5d8: Adds new route from TrainSimulations - Pull request #857 at 9afc8c3: Adding Air Flow Meters - Pull request #863 at a34b857: Alternate preset 3D cabviewpoints - Pull request #864 at e71bc5a: Fixes for Undesired Emergency Applications - Pull request #865 at 776d6df: Dispatcher window improvements - Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars - Pull request #870 at 5cb32fa: Fix water restore - Pull request #871 at c2388e6: Signal aspects are multiplied when reopening Dispatcher Window - Pull request #872 at 00c5b8b: Fix Retainer State Disappearing from HUD on Restore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for http://www.elvastower.com/forums/index.php?/topic/37438-retainer-state-not-updated-on-restore/page__pid__300516#entry300516
The retainer state on the Alt + F5 brake HUD would fail to show the retainer state after loading from a saved game (the "RetValve" column would be blank, regardless of the presence/lack of retaining valves on the equipment in the activity). This is because the retainer debug state is only updated when the retainer state changes (and the state is not changed upon loading). Note that this is not an issue with the functionality of the retaining valves, just a bug with displaying them.
Fixed by simply adding the RetainerDebugState to save and restore. Whatever the state is will automatically be recovered when loading a save without the need to re-initialize the variable.