Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix water restore #870

Merged
merged 1 commit into from Sep 16, 2023
Merged

Fix water restore #870

merged 1 commit into from Sep 16, 2023

Conversation

cesarBLG
Copy link
Contributor

@cesarBLG cesarBLG commented Sep 5, 2023

http://www.elvastower.com/forums/index.php?/topic/37430-water-quantity-increased-after-save/

Remove workaround introduced due to previously broken Restore procedure

@cesarBLG cesarBLG added the bug Something isn't working label Sep 5, 2023
twpol pushed a commit that referenced this pull request Sep 5, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #860 at 82a584a: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 18c5481: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
twpol pushed a commit that referenced this pull request Sep 6, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at e71bc5a: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
twpol pushed a commit that referenced this pull request Sep 7, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 594df54: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at e71bc5a: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
twpol pushed a commit that referenced this pull request Sep 9, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 594df54: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at e71bc5a: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
- Pull request #871 at c2388e6: Signal aspects are multiplied when reopening Dispatcher Window
twpol pushed a commit that referenced this pull request Sep 10, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 594df54: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at e71bc5a: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
- Pull request #871 at c2388e6: Signal aspects are multiplied when reopening Dispatcher Window
- Pull request #872 at 00c5b8b: Fix Retainer State Disappearing from HUD on Restore
twpol pushed a commit that referenced this pull request Sep 10, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 3e672a8: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at e71bc5a: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
- Pull request #871 at c2388e6: Signal aspects are multiplied when reopening Dispatcher Window
- Pull request #872 at 00c5b8b: Fix Retainer State Disappearing from HUD on Restore
twpol pushed a commit that referenced this pull request Sep 14, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 3e672a8: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at e71bc5a: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
- Pull request #873 at cf0ed99: Reduce allocations in signal script
twpol pushed a commit that referenced this pull request Sep 14, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 3e672a8: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at e71bc5a: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
- Pull request #873 at cf0ed99: Reduce allocations in signal script
- Pull request #874 at d500329: Dynamic brake controller refactoring
twpol pushed a commit that referenced this pull request Sep 14, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 3e672a8: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #863 at 516825f: Alternate preset 3D cabviewpoints
- Pull request #864 at e71bc5a: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
- Pull request #873 at cf0ed99: Reduce allocations in signal script
- Pull request #874 at d500329: Dynamic brake controller refactoring
twpol pushed a commit that referenced this pull request Sep 15, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 3e672a8: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at ce3bc1f: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
- Pull request #873 at cf0ed99: Reduce allocations in signal script
- Pull request #874 at d500329: Dynamic brake controller refactoring
twpol pushed a commit that referenced this pull request Sep 15, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at fc94364: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at ce3bc1f: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
- Pull request #873 at cf0ed99: Reduce allocations in signal script
- Pull request #874 at d500329: Dynamic brake controller refactoring
twpol pushed a commit that referenced this pull request Sep 15, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 82d3be2: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at ce3bc1f: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
- Pull request #873 at cf0ed99: Reduce allocations in signal script
- Pull request #874 at d500329: Dynamic brake controller refactoring
twpol pushed a commit that referenced this pull request Sep 15, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at f6ca1e1: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at ce3bc1f: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
- Pull request #873 at cf0ed99: Reduce allocations in signal script
- Pull request #874 at d500329: Dynamic brake controller refactoring
Copy link
Contributor

@Csantucci Csantucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's OK to me, it's also a code cleanup. Thank you!

twpol pushed a commit that referenced this pull request Sep 16, 2023
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at f6ca1e1: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
- Pull request #873 at cf0ed99: Reduce allocations in signal script
- Pull request #874 at d500329: Dynamic brake controller refactoring
@cesarBLG cesarBLG merged commit d7b38a5 into openrails:master Sep 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
2 participants