You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The resultant top level ObjectNode that gets put into MagpieEnvelope should contain 3 fields (configuration, supplementaryConfiguration, and tags).
When in doubt, the raw JSON on Open Raven's clusters should be authoritative WITH ONE DEVIATION: Use camelCase for all top level keys.
For example in S3 buckets: supplementaryConfiguration.ServerSideEncryptionConfiguration should become supplementaryConfiguration.serverSideEncryptionConfiguration (note the lower case 's'). We are standardizing and ensuring consistency in naming.
All service updates fall under this ticket and can be submitted as a single (albeit massive) PR.
The text was updated successfully, but these errors were encountered:
In the AWS Discovery services (for example: https://github.com/openraven/magpie/blob/main/magpie-aws/src/main/java/io/openraven/magpie/plugins/aws/discovery/services/S3Discovery.java) relocate any current top level fields (with the exception of the
tags
and current TODO) into/supplementaryConfiguration
.Using
S3Discovery
as an example it should take the form:The resultant top level
ObjectNode
that gets put intoMagpieEnvelope
should contain 3 fields (configuration
,supplementaryConfiguration
, andtags
).When in doubt, the raw JSON on Open Raven's clusters should be authoritative WITH ONE DEVIATION: Use camelCase for all top level keys.
For example in S3 buckets:
supplementaryConfiguration.ServerSideEncryptionConfiguration
should becomesupplementaryConfiguration.serverSideEncryptionConfiguration
(note the lower case 's'). We are standardizing and ensuring consistency in naming.All service updates fall under this ticket and can be submitted as a single (albeit massive) PR.
The text was updated successfully, but these errors were encountered: