Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP/2 supporting #26

Open
boyxuper opened this issue Apr 9, 2016 · 7 comments
Open

HTTP/2 supporting #26

boyxuper opened this issue Apr 9, 2016 · 7 comments

Comments

@boyxuper
Copy link

boyxuper commented Apr 9, 2016

Since lua_nginx_module been support HTTP/2: openresty/lua-nginx-module#566
Is there any chance we could also get drizzle-nginx-module to work with HTTP/2 ?

@agentzh
Copy link
Member

agentzh commented Apr 9, 2016

@boyxuper You should try it out yourself. I think it should just work. I've never tested it though.

@agentzh
Copy link
Member

agentzh commented Apr 9, 2016

@boyxuper BTW, ngx_lua does not fully support HTTP/2 yet.

@boyxuper
Copy link
Author

boyxuper commented Apr 9, 2016

@agentzh Thx for the fast reply. I've tried drizzle with HTTP/2 but failed, and here's the error log:

2016/04/10 02:23:11 [alert] 5834#0: *436835 epoll_ctl(1, 43) failed (17: File exists), client: 127.0.0.1, server: , request: "GET /item/245136127 HTTP/2.0", subrequest: "/_read_mysql", host: "127.0.0.1"

I'm afraid that I'm not so familiar with drizzle-nginx-module code, but I'd like to try, what should I do to fix this?

@agentzh
Copy link
Member

agentzh commented Apr 10, 2016

@boyxuper I guess we should migrate the following two code snippets guarded by NGX_HTTP_V2 in src/http/ngx_http_upstream.c of the latest NGINX core to ngx_drizzle's src/ngx_http_drizzle_upstream.c file:

src/http/ngx_http_upstream.c
490:#if (NGX_HTTP_V2)
1176:#if (NGX_HTTP_V2)

@jmealo
Copy link

jmealo commented Apr 21, 2016

@boyxuper @agentzh openresty/lua-nginx-module#252 (comment) I'm not sure if this is related.

@agentzh
Copy link
Member

agentzh commented Apr 26, 2016

@jmealo Yeah, the error message is similar. But I cannot derive more from just the error message itself. Patches welcome :)

@adrhc
Copy link

adrhc commented Sep 12, 2024

it doesn't work with HTTP/2:

2024/09/12 21:03:01 [alert] 1863890#0: *14 epoll_ctl(1, 26) failed (17: File exists), client: 192.168.0.2, server: adrhc.go.ro, request: "GET /albums/mysql/image/1000 HTTP/2.0", host: "adrhc.go.ro"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants