-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a Jenkinsfile for Librecores CI in mor1kx #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has it been tested locally @Nancy-Chauhan ? I can enable CI for your local branch on ci.librecores.org f you grant @librecores-ci-bot Write access to your repo
Jenkinsfile
Outdated
} | ||
stage('run-parallel-jobs') { | ||
steps { | ||
parallel( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could have definitely optimize it if we had native support of config matrixes in Declarative pipeline, but it s still in progress
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has it been tested locally @Nancy-Chauhan ? I can enable CI for your local branch on ci.librecores.org f you grant @librecores-ci-bot Write access to your repo
Yes , I have tested locally @oleg-nenashev , still need to do changes and I have send invite to librecores-ci-bot for write access .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the tabulation mess, I'd say this is an example of a code where Declarative Pipeline does not have advantages being compared to Scripted. Maybe the Matrix feature could help to simplify environment management, cc @bitwiseman
Reference CI run on ci.jenkins.io: https://ci.librecores.org/job/Sandbox/job/Nancy-Chauhan/job/mor1kx/job/Jenkinsfile/ |
c2d99cd
to
37ff5f5
Compare
@oleg-nenashev @stffrdhrn Can you please check the latest commit . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some refactoring would be still useful, but it is much more readable now. Thanks!
@oleg-nenashev @stffrdhrn Is it good to be merged now ? along with openrisc/or1k_marocchino#12 |
Are you planning to integrate Jenkins into the pull request build checks? I.e. this can run instead of Travis? Also, do you have a badge you can put in the readme to indicate build status? Are those next steps? |
Yes @stffrdhrn , it will do same work that of travis and can run instead of it . I can later built this jenkinsfile only .I think for badge i can add once this repo and also or1k_marocchino is on https://ci.librecores.org/ |
CI bot here. Please merge this pull request so that I can run CI on ci.librecores.org |
Solves #83