Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Jenkinsfile for Librecores CI in mor1kx #84

Merged
merged 3 commits into from
Jul 3, 2019

Conversation

Nancy-Chauhan
Copy link
Contributor

Solves #83

Copy link

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has it been tested locally @Nancy-Chauhan ? I can enable CI for your local branch on ci.librecores.org f you grant @librecores-ci-bot Write access to your repo

Jenkinsfile Outdated
}
stage('run-parallel-jobs') {
steps {
parallel(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could have definitely optimize it if we had native support of config matrixes in Declarative pipeline, but it s still in progress

Copy link
Contributor Author

@Nancy-Chauhan Nancy-Chauhan Jun 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has it been tested locally @Nancy-Chauhan ? I can enable CI for your local branch on ci.librecores.org f you grant @librecores-ci-bot Write access to your repo

Yes , I have tested locally @oleg-nenashev , still need to do changes and I have send invite to librecores-ci-bot for write access .

@Nancy-Chauhan Nancy-Chauhan marked this pull request as ready for review June 26, 2019 18:23
Copy link

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the tabulation mess, I'd say this is an example of a code where Declarative Pipeline does not have advantages being compared to Scripted. Maybe the Matrix feature could help to simplify environment management, cc @bitwiseman

@oleg-nenashev
Copy link

@Nancy-Chauhan
Copy link
Contributor Author

@oleg-nenashev @stffrdhrn Can you please check the latest commit .

Copy link

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some refactoring would be still useful, but it is much more readable now. Thanks!

Jenkinsfile Outdated Show resolved Hide resolved
Jenkinsfile Outdated Show resolved Hide resolved
@Nancy-Chauhan
Copy link
Contributor Author

@oleg-nenashev @stffrdhrn Is it good to be merged now ? along with openrisc/or1k_marocchino#12

@stffrdhrn
Copy link
Member

Are you planning to integrate Jenkins into the pull request build checks? I.e. this can run instead of Travis? Also, do you have a badge you can put in the readme to indicate build status?

Are those next steps?

@Nancy-Chauhan
Copy link
Contributor Author

Nancy-Chauhan commented Jul 2, 2019

Yes @stffrdhrn , it will do same work that of travis and can run instead of it . I can later built this jenkinsfile only .I think for badge i can add once this repo and also or1k_marocchino is on https://ci.librecores.org/

@librecores-ci-bot
Copy link

CI bot here. Please merge this pull request so that I can run CI on ci.librecores.org

@stffrdhrn stffrdhrn merged commit 6ce7d74 into openrisc:master Jul 3, 2019
@Nancy-Chauhan Nancy-Chauhan deleted the Jenkinsfile branch July 3, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants