Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download 2018 data for from netfile API #78

Closed
tommy-stone opened this issue Aug 26, 2020 · 3 comments
Closed

Download 2018 data for from netfile API #78

tommy-stone opened this issue Aug 26, 2020 · 3 comments
Assignees

Comments

@tommy-stone
Copy link
Contributor

Candidate data also goes back to 2018. Download data from netfile API, name file netfile_api_2019.csv and save to src/assests/data

@robertgz
Copy link
Member

robertgz commented Aug 27, 2020

Should the 2018 data be in the same file with the 2019 data? Or should the 2018 data be in its own file and be named netfile_api_2018.csv?

Should the download script also be updated to include the 2018 data?

@tommy-stone
Copy link
Contributor Author

The 2018 data should have it's own file called netfile_api_2018.csv and will be in the same folder as the 2019 and 2020 data.

I've created a separate issue to include the netfile_api_2018.csv into the calculations.

@tommy-stone
Copy link
Contributor Author

Closing open issue as item is complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants