Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADR: Create a mono repository #120

Open
Sander3003 opened this issue Jun 14, 2023 · 2 comments
Open

ADR: Create a mono repository #120

Sander3003 opened this issue Jun 14, 2023 · 2 comments
Assignees
@pascalwilbrink

Comments

@Sander3003
Copy link
Member

Sander3003 commented Jun 14, 2023 •
edited
Loading

[TODO: convert it into an ADR]

Use https://lerna.js.org/ (or others) to create 1 repository for components

Motivations to do so:
one code owner to rule them all
One storybook for easy checking/testing components
1 NPM token
Easy copying
Lower workload on the developers
1 ESlint

Disadvantages:
1 maintainers for all compontents (mitigation: can be splitup in multiple mono repositories to make it manageble)
Risk of overlapping (migitation: can be enforced by Lerna)
@Sander3003 Sander3003 changed the title Create a mono repository ADR: Create a mono repository Jun 14, 2023
@tamasrusz
Copy link

We are working with pnpm workspace

@pascalwilbrink pascalwilbrink mentioned this issue Jun 30, 2023
Open
@Sander3003
Copy link
Member Author

https://wiki.lfenergy.org/display/SHP/%5BADR%5D+Group+projects+together+in+a+monorepo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pascalwilbrink pascalwilbrink

Labels
None yet
Projects
Next
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pascalwilbrink @Sander3003 @tamasrusz