Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Data Table Sort no more persisted since 2.5.0 #3642

Closed
pmarjou opened this issue Mar 21, 2023 · 7 comments
Closed

[BUG] Data Table Sort no more persisted since 2.5.0 #3642

pmarjou opened this issue Mar 21, 2023 · 7 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers tableVis table visualization v2.7.0

Comments

@pmarjou
Copy link

pmarjou commented Mar 21, 2023

Describe the bug
Since version 2.5.0 the sort in the data table header is no more persisted at saved.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new Data Table Visualization
  2. Select an index pattern
  3. Add a Bucket Terms Aggregation
    image
  4. Sort "Asc" in the data table header
    image
  5. Save the visualization
  6. Refresh the page in the browser
  7. The sort is still "Desc"
    image

Expected behavior
The sort should be persisted at visualization save.

OpenSearch Version
2.5.0

Dashboards Version
2.5.0

@pmarjou pmarjou added bug Something isn't working untriaged labels Mar 21, 2023
@abbyhu2000 abbyhu2000 self-assigned this Mar 21, 2023
@abbyhu2000
Copy link
Member

Was able to reproduce the issue:

Before release 2.5, the order can be changed by simply clicking the column title. And the sorting order will be persisted across refresh and also saved in the saved object.
Screen Shot 2023-03-21 at 2 24 15 PM

After release 2.5, the order can be changed by clicking the column title, and select either sort desc or sort asc. However, the sorting order will not be persisted across refresh, and it is also not saved in the saved object.
Screen Shot 2023-03-21 at 2 27 15 PM

@ashwin-pc ashwin-pc added the good first issue Good for newcomers label Mar 21, 2023
@abbyhu2000
Copy link
Member

abbyhu2000 commented Mar 22, 2023

After investigation, verified that the regression was caused by this PR (replace table viz with react and data grid): #2863

@seanneumann
Copy link
Contributor

Let's get this fixed for 2.7.

@joshuarrrr
Copy link
Member

@abbyhu2000 Are you planning to fix this, or do we need to assign someone else?

@abbyhu2000
Copy link
Member

@joshuarrrr This issue is blocked by vis builder #3650.

Once @ashwin-pc gets the fix in for vis builder, @ananzh will push her fix for table vis. I will assign them to this issue.

@abbyhu2000 abbyhu2000 assigned ashwin-pc and ananzh and unassigned abbyhu2000 Mar 23, 2023
@joshuarrrr
Copy link
Member

We ran out of time to make the updates after the blocking change was merged. So this will go in 2.8.0 instead.

@joshuarrrr joshuarrrr added v2.8.0 and removed v2.7.0 labels Apr 20, 2023
@ananzh ananzh added v2.7.0 and removed v2.8.0 labels May 31, 2023
@ananzh
Copy link
Member

ananzh commented May 31, 2023

This bug is fixed #3650 which allows table vis to re-use uiState. I have verified that this bug is fixed after the above PR merged.

Since #3650 is released in 2.7, I will updated the tag back to 2.7 and close it.

@ananzh ananzh closed this as completed May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers tableVis table visualization v2.7.0
Projects
None yet
Development

No branches or pull requests

6 participants