Reporting anything sumukh #392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: EC2 Default User <ec2-user@ip-172-31-41-15.us-west-2.compute.internal>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: EC2 Default User <ec2-user@ip-172-31-41-15.us-west-2.compute.internal>
…put validation Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
Signed-off-by: David Cui <davidcui@amazon.com>
…avor of url Signed-off-by: David Cui <davidcui@amazon.com>
…d constants Signed-off-by: David Cui <davidcui@amazon.com>
|
@sumukhswamy I see the DCO fails for last 2 commits. You can amend them and push again. Also, let's add more description in the issue about the draft created. |
+1 To start with, let's add in the PR description what the changes being added are (e.g SAML, cognito, etc.) |
Codecov Report
@@ Coverage Diff @@
## main #392 +/- ##
=========================================
Coverage 74.27% 74.27%
Complexity 383 383
=========================================
Files 94 94
Lines 3984 3984
Branches 641 641
=========================================
Hits 2959 2959
Misses 891 891
Partials 134 134
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
Lgtm |
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: Sumukh Swamy <sumukhhs@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
…h type Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
…vided the authentication into multiple functions and added error handling for login fails Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
|
closing an older PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.