Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Changelog Verifier GitHub Action generates seven notification emails #481

Closed
dbwiddis opened this issue Jan 31, 2024 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@dbwiddis
Copy link
Member

dbwiddis commented Jan 31, 2024

What is the bug?

When submitting a pull request without a change log entry, seven notification emails are sent. (Eight if the submitter is not a codeowner.)

How can one reproduce the bug?

Submit a pull request without a change log entry or skip-changelog tag.

What is the expected behavior?

Zero or one notification emails to project maintainers.

Do you have any screenshots?

Screenshot 2024-01-31 at 9 44 00 AM

Do you have any additional context?

The action is set to run on types: [opened, edited, review_requested, synchronize, reopened, ready_for_review, labeled, unlabeled] so it runs:

  • when the PR is opened
  • when the backport label is applied
  • when reviews are requested (5 notifications, one for each of the 5 codeowners other than the submitter)

Suggested fix:

@dbwiddis dbwiddis added bug Something isn't working untriaged labels Jan 31, 2024
@dbwiddis
Copy link
Member Author

FYI, the problem is worse on OpenSearch core:
Screenshot 2024-01-31 at 3 49 42 PM

@dbwiddis dbwiddis removed the untriaged label Feb 2, 2024
@dbwiddis
Copy link
Member Author

dbwiddis commented Apr 5, 2024

Fixed in #646

@dbwiddis dbwiddis closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant