You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think we can get rid of the whole JNIService and move the calls to the respective Engines. If we were to do this, we would then just have FaissService and NmslibService in the jni module.
If we were to do this, we could move FaissService and NmslibService into the jni directory in the root project and create dedicated gradle sub-projects. Then, for the plugin itself, we could take a proper dependency on the JNI related code itself.
I think this would properly decouple the JNI library/Java bindings from the plugin. This would allow us to more easily:
Separate plugin build from library build (this has been an issue with build infra in many instances cc: @peterzhuamazon).
This would allow us to decouple library versioning from plugin versioning. If we dont change the library, we dont need to release it with every release
Description
Following up on discussion here: #1529 (comment)
I think we can get rid of the whole JNIService and move the calls to the respective Engines. If we were to do this, we would then just have FaissService and NmslibService in the jni module.
If we were to do this, we could move FaissService and NmslibService into the jni directory in the root project and create dedicated gradle sub-projects. Then, for the plugin itself, we could take a proper dependency on the JNI related code itself.
I think this would properly decouple the JNI library/Java bindings from the plugin. This would allow us to more easily:
lib
folder after plugin installation usingopensearch-plugin
CLI tool #1408) without doing hacks like adding to our zip in the build scriptThe text was updated successfully, but these errors were encountered: