Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release]: SQL JDBC driver #3505

Closed
Yury-Fridlyand opened this issue May 12, 2023 · 8 comments
Closed

[release]: SQL JDBC driver #3505

Yury-Fridlyand opened this issue May 12, 2023 · 8 comments
Labels

Comments

@Yury-Fridlyand
Copy link
Contributor

Did you read the on-boarding document

What is the name of your component?

sqj-jdbc

What is the link to your GitHub repo?

https://github.com/opensearch-project/sql-jdbc

Targeted release date

11.05.2023

Where should we publish this component?

Maven

What type of artifact(s) will be generated for this component?

non-shadow jar

Have you completed the required reviews including security reviews, UX reviews?

Have you on-boarded automated security scanning for the GitHub repo associated with this component?

Additional context

No response

@Yury-Fridlyand Yury-Fridlyand added release untriaged Issues that have not yet been triaged labels May 12, 2023
@gaiksaya
Copy link
Member

Hi @Yury-Fridlyand , sql-jdbc is already on boarded to 1-click release process. See #2692 (comment)
Is there something more required?

@gaiksaya gaiksaya removed the untriaged Issues that have not yet been triaged label May 12, 2023
@Yury-Fridlyand
Copy link
Contributor Author

Hi
Yes, I'm aware of it. I created a tag, but Jenkins CI wasn't triggered. Something is missing or misconfigured, but I don't know what.

@gaiksaya
Copy link
Member

I see that the release was released on GitHub. From releasing.md:

Please note that the release workflow is triggered only if created release is in draft state.

The release will be automatically published once the artifacts are released on maven. Can you delete the release and then re-cut the tag and just leave at that. All other things should be taken care automatically.

Thanks!

@Yury-Fridlyand
Copy link
Contributor Author

Ouch. Will try.

@Yury-Fridlyand
Copy link
Contributor Author

That worked, but CI failed @gaiksaya.
What can we do?

@gaiksaya
Copy link
Member

I just resend the webhook trigger. Looks like it went through! Not sure for what reason the asset_url was going null.

https://github.com/opensearch-project/sql-jdbc/releases/tag/1.3.0.0
https://aws.oss.sonatype.org/content/repositories/releases/org/opensearch/driver/opensearch-sql-jdbc/1.3.0.0/

@gaiksaya
Copy link
Member

Closing this issue as release was successful. Also created an issue to on-board sql-jdbc to 2PR approval process: opensearch-project/sql-jdbc#77

@Yury-Fridlyand
Copy link
Contributor Author

Woohoo! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants