-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jackson-databind and jackson-annotations now coming from core #349
Conversation
Signed-off-by: David Zane <davizane@amazon.com>
WhiteSource Security Check failing due to bad Netty version. I will fix that in a separate PR |
Codecov Report
@@ Coverage Diff @@
## main #349 +/- ##
=========================================
Coverage 70.82% 70.82%
Complexity 372 372
=========================================
Files 44 44
Lines 2581 2581
Branches 174 174
=========================================
Hits 1828 1828
Misses 641 641
Partials 112 112 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-349-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b8d3a4c996788c832355d17a074c14b8e733e52c
# Push it to GitHub
git push --set-upstream origin backport/backport-349-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
…349) Signed-off-by: David Zane <davizane@amazon.com>
…om core (opensearch-project#349)' Signed-off-by: Ryan Bogan <rbogan@amazon.com>
…om core (opensearch-project#349)' Signed-off-by: Ryan Bogan <rbogan@amazon.com>
…ore' (#369) * Revert 'Remove jackson-databind and jackson-annotations now coming from core (#349)' Signed-off-by: Ryan Bogan <rbogan@amazon.com> * update licenses Signed-off-by: Kiran Prakash <awskiran@amazon.com> * update licenses Signed-off-by: Kiran Prakash <awskiran@amazon.com> Signed-off-by: Ryan Bogan <rbogan@amazon.com> Signed-off-by: Kiran Prakash <awskiran@amazon.com> Co-authored-by: Ryan Bogan <rbogan@amazon.com>
…pensearch-project#349) Signed-off-by: David Zane <davizane@amazon.com>
…ore' (opensearch-project#369) * Revert 'Remove jackson-databind and jackson-annotations now coming from core (opensearch-project#349)' Signed-off-by: Ryan Bogan <rbogan@amazon.com> * update licenses Signed-off-by: Kiran Prakash <awskiran@amazon.com> * update licenses Signed-off-by: Kiran Prakash <awskiran@amazon.com> Signed-off-by: Ryan Bogan <rbogan@amazon.com> Signed-off-by: Kiran Prakash <awskiran@amazon.com> Co-authored-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: David Zane davizane@amazon.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Fixes #344
Describe the solution you are proposing
Remove direct jackson-databind and jackson-annotations direct dependency in PA.
Also pick Jackson versions from OpenSearch props file https://github.com/opensearch-project/OpenSearch/blob/main/buildSrc/version.properties
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.