Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jackson-databind and jackson-annotations now coming from core … #351

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

dzane17
Copy link
Contributor

@dzane17 dzane17 commented Dec 29, 2022

…(#349)

Signed-off-by: David Zane davizane@amazon.com
(cherry picked from commit b8d3a4c)

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you are proposing
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…349)

Signed-off-by: David Zane <davizane@amazon.com>
(cherry picked from commit b8d3a4c)
@dzane17 dzane17 requested a review from a team December 29, 2022 01:25
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

Merging #351 (da90bf6) into 2.x (f40b7e1) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x     #351      +/-   ##
============================================
- Coverage     70.82%   70.67%   -0.16%     
+ Complexity      372      371       -1     
============================================
  Files            44       44              
  Lines          2581     2581              
  Branches        174      174              
============================================
- Hits           1828     1824       -4     
- Misses          641      644       +3     
- Partials        112      113       +1     
Impacted Files Coverage Δ
...ormanceanalyzer/writer/EventLogQueueProcessor.java 55.95% <0.00%> (-4.77%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dzane17 dzane17 merged commit 18b9fb8 into 2.x Dec 29, 2022
@dzane17 dzane17 deleted the backport/backport-349-to-2.x branch December 29, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants