Provide empty states for Findings and Alerts page #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h-project#471 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #494 +/- ##
==========================================
- Coverage 35.62% 35.52% -0.11%
==========================================
Files 119 119
Lines 3253 3257 +4
Branches 521 525 +4
==========================================
- Hits 1159 1157 -2
- Misses 1971 1975 +4
- Partials 123 125 +2 see 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
AWSHurneyt
approved these changes
Mar 31, 2023
…-analytics-dashboards-plugin into Provide_empty_states_for_Findings_and_Alerts_page
amsiglan
approved these changes
Apr 6, 2023
jovancacvetkovic
changed the title
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Apr 13, 2023
…h-project#471 (opensearch-project#494) Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
1 task
AWSHurneyt
added a commit
that referenced
this pull request
Apr 14, 2023
AWSHurneyt
added a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Jun 8, 2023
…h-project#471 (opensearch-project#494) (opensearch-project#519) Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt
added a commit
that referenced
this pull request
Jun 8, 2023
* [FEATURE] Provide empty states for Findings and Alerts page #471 (#494) (#519) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * fixed recent alerts & finding order; count for pie chart (#576) (#579) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 3812055) Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Show required field mappings only for enabled rules (#418) (#481) * show required field mappings only for enabled rules Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated mock custom rule to match mapping in backend Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 1bbc4c5) Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Resolved merge conflicts after cherry-picking PR 418. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * use user provided end date for x-axis calc (#584) (#604) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit c280bad) Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
AWSHurneyt
added a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…h-project#471 (opensearch-project#494) (opensearch-project#519) Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
amsiglan
pushed a commit
that referenced
this pull request
Mar 16, 2024
* [FEATURE] Provide empty states for Findings and Alerts page #471 (#494) (#519) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * fixed recent alerts & finding order; count for pie chart (#576) (#579) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 3812055) Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Show required field mappings only for enabled rules (#418) (#481) * show required field mappings only for enabled rules Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated mock custom rule to match mapping in backend Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 1bbc4c5) Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Resolved merge conflicts after cherry-picking PR 418. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * use user provided end date for x-axis calc (#584) (#604) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit c280bad) Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> cr: https://code.amazon.com/reviews/CR-93561817
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds empty state messages for the Findings and Alerts page.
Find all the mocks attached on issue #471
Issues Resolved
Resolves #471
Screenshots
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.