Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Provide empty states for Findings and Alerts page #471

Closed
kamingleung opened this issue Mar 2, 2023 · 0 comments · Fixed by #494
Closed

[FEATURE] Provide empty states for Findings and Alerts page #471

kamingleung opened this issue Mar 2, 2023 · 0 comments · Fixed by #494
Labels
enhancement New feature or request

Comments

@kamingleung
Copy link

kamingleung commented Mar 2, 2023

Is your feature request related to a problem?

Issues today: On the findings and alerts page, there are no clear messages or guidance on what to do when there are no findings or alerts found within the time range.
Current behavior in Findings:
image
Current behavior in Alerts:
image

What solution would you like?

Findings page

Once the UI had finished fetching the data, and there are no findings, we should replace the chart with an empty prompt:
image

  • Header: No findings
  • Description: Adjust the time range to see more results or create a detector to generate findings.
  • Clicking on the link create a detector will go to the Create detector page
  • Use OUI empty prompt component

We should also adjust the empty state text on the Findings table below:
image

No findings.
Adjust the time range to see more results.

Alerts page

Once the UI had finished fetching the data, and there are no alerts, we should replace the chart with an empty prompt:
image

  • Header: No alerts
  • Description: Adjust the time range to see more results or create alert triggers in your detectors to generate alerts.
  • Clicking on the link detectors will go to the Detectors page (with a list of detectors)
  • Use OUI empty prompt component

We should also adjust the empty state text on the Alerts table below:
image

No alerts.
Adjust the time range to see more results.
@kamingleung kamingleung added enhancement New feature or request untriaged labels Mar 2, 2023
jovancacvetkovic added a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Mar 28, 2023
…h-project#471

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
AWSHurneyt pushed a commit that referenced this issue Apr 10, 2023
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Apr 10, 2023
Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
(cherry picked from commit 0452437)
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Apr 13, 2023
AWSHurneyt added a commit that referenced this issue Apr 14, 2023
… (#519)

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
amsiglan added a commit that referenced this issue May 4, 2023
* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Provide empty states for Findings and Alerts page #471

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks #498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks #498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks #498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component #502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component #502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component #502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component #502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Feature] update detector details component #504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Feature] update detector details component #504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Update detector details component #504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan added a commit to amsiglan/security-analytics-dashboards-plugin that referenced this issue May 5, 2023
* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Provide empty states for Findings and Alerts page opensearch-project#471

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Feature] update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Feature] update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan added a commit to amsiglan/security-analytics-dashboards-plugin that referenced this issue May 5, 2023
* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Provide empty states for Findings and Alerts page opensearch-project#471

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Feature] update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Feature] update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
amsiglan added a commit that referenced this issue May 5, 2023
…577)

* [BUG] Finding's fly-out has no correlations if open from alerts (#558)

* [BUG] Finding's fly-out has no correlations if open from alerts #557

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review from #558 (comment)

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress | create detector specs update (#518)

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Provide empty states for Findings and Alerts page #471

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks #498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests #493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks #498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks #498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component #502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component #502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component #502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component #502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Feature] update detector details component #504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Feature] update detector details component #504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Update detector details component #504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] No space between the detector details and the rule panel #522
[BUG] A rule flyout without references have an empty link #521
[FEATURE] Update header size to use euiTitle--small #520

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* added link to rules; simplified rule parsing (#571)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* [FEATURE] Finding flyout loading state (#562)

* [FEATURE] Set loading state for finding fly-out until the data is ready #559

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* fix tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* fix tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add correlation rule details into the finding details flyout #563 (#565)

* Add correlation rule details into the finding details flyout #563

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add correlation rule details into the finding details flyout #563

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* fix tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add correlation rule details into the finding details flyout #563 #565

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add correlation rule details into the finding details flyout #563 #565

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add correlation rule details into the finding details flyout #563 #565

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* UX improvements for correlation engine (#561)

* passing props for date time filter (#551)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* added loading state

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* ux improvements

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* transform vega-lite files for jest testing

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

---------

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* Add a details button to open the findings flyout from the correlations page. (#572)

* Add a details button to open the findings flyout from the correlations page. #564

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add a details button to open the findings flyout from the correlations page. #564

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Add a details button to open the findings flyout from the correlations page. #564

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* fix tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Wrong field mappings for the cloud trail logs #573

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Wrong field mappings for the cloud trail logs (#574)

* Wrong field mappings for the cloud trail logs #573

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Wrong field mappings for the cloud trail logs #573

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Wrong field mappings for the cloud trail logs #573

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated workflow file

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated osd branch for cypress tests

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
AWSHurneyt added a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Jun 8, 2023
AWSHurneyt added a commit that referenced this issue Jun 8, 2023
* [FEATURE] Provide empty states for Findings and Alerts page #471 (#494) (#519)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* fixed recent alerts & finding order; count for pie chart (#576) (#579)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
(cherry picked from commit 3812055)

Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* Show required field mappings only for enabled rules (#418) (#481)

* show required field mappings only for enabled rules

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated mock custom rule to match mapping in backend

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

---------

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
(cherry picked from commit 1bbc4c5)

Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Resolved merge conflicts after cherry-picking PR 418.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* use user provided end date for x-axis calc (#584) (#604)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
(cherry picked from commit c280bad)

Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

---------

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
AWSHurneyt added a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Oct 12, 2023
…h-project#471 (opensearch-project#494) (opensearch-project#519)

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Oct 12, 2023
…pensearch-project#577)

* [BUG] Finding's fly-out has no correlations if open from alerts (opensearch-project#558)

* [BUG] Finding's fly-out has no correlations if open from alerts opensearch-project#557

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review from opensearch-project#558 (comment)

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress | create detector specs update (opensearch-project#518)

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Provide empty states for Findings and Alerts page opensearch-project#471

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Feature] update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Feature] update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* added link to rules; simplified rule parsing (opensearch-project#571)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* [FEATURE] Finding flyout loading state (opensearch-project#562)

* [FEATURE] Set loading state for finding fly-out until the data is ready opensearch-project#559

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* fix tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* fix tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add correlation rule details into the finding details flyout opensearch-project#563 (opensearch-project#565)

* Add correlation rule details into the finding details flyout opensearch-project#563

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add correlation rule details into the finding details flyout opensearch-project#563

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* fix tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* UX improvements for correlation engine (opensearch-project#561)

* passing props for date time filter (opensearch-project#551)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* added loading state

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* ux improvements

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* transform vega-lite files for jest testing

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

---------

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* Add a details button to open the findings flyout from the correlations page. (opensearch-project#572)

* Add a details button to open the findings flyout from the correlations page. opensearch-project#564

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add a details button to open the findings flyout from the correlations page. opensearch-project#564

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Add a details button to open the findings flyout from the correlations page. opensearch-project#564

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* fix tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Wrong field mappings for the cloud trail logs (opensearch-project#574)

* Wrong field mappings for the cloud trail logs opensearch-project#573

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated workflow file

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated osd branch for cypress tests

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
amsiglan pushed a commit that referenced this issue Mar 16, 2024
* [FEATURE] Provide empty states for Findings and Alerts page #471 (#494) (#519)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* fixed recent alerts & finding order; count for pie chart (#576) (#579)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
(cherry picked from commit 3812055)

Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* Show required field mappings only for enabled rules (#418) (#481)

* show required field mappings only for enabled rules

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated mock custom rule to match mapping in backend

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

---------

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
(cherry picked from commit 1bbc4c5)

Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Resolved merge conflicts after cherry-picking PR 418.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* use user provided end date for x-axis calc (#584) (#604)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
(cherry picked from commit c280bad)

Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

---------

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

cr: https://code.amazon.com/reviews/CR-93561817
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants