-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.5] Manually backported PRs 418, 471, 576, and 584. #623
Merged
AWSHurneyt
merged 5 commits into
opensearch-project:2.5
from
AWSHurneyt:2.5_manual_backports
Jun 8, 2023
Merged
[Backport 2.5] Manually backported PRs 418, 471, 576, and 584. #623
AWSHurneyt
merged 5 commits into
opensearch-project:2.5
from
AWSHurneyt:2.5_manual_backports
Jun 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h-project#471 (opensearch-project#494) (opensearch-project#519) Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
…project#576) (opensearch-project#579) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 3812055) Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
…ct#418) (opensearch-project#481) * show required field mappings only for enabled rules Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated mock custom rule to match mapping in backend Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 1bbc4c5) Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
…pensearch-project#604) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit c280bad) Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Codecov Report
@@ Coverage Diff @@
## 2.5 #623 +/- ##
==========================================
- Coverage 15.55% 15.52% -0.04%
==========================================
Files 111 111
Lines 2963 2982 +19
Branches 459 465 +6
==========================================
+ Hits 461 463 +2
- Misses 2463 2480 +17
Partials 39 39 |
amsiglan
approved these changes
Jun 8, 2023
lezzago
approved these changes
Jun 8, 2023
amsiglan
pushed a commit
that referenced
this pull request
Mar 16, 2024
* [FEATURE] Provide empty states for Findings and Alerts page #471 (#494) (#519) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * fixed recent alerts & finding order; count for pie chart (#576) (#579) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 3812055) Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Show required field mappings only for enabled rules (#418) (#481) * show required field mappings only for enabled rules Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated mock custom rule to match mapping in backend Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit 1bbc4c5) Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Resolved merge conflicts after cherry-picking PR 418. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * use user provided end date for x-axis calc (#584) (#604) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> (cherry picked from commit c280bad) Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> cr: https://code.amazon.com/reviews/CR-93561817
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manually backported PRs #418, #471, #576, and #584.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.