[FEATURE] Finding flyout loading state #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-project#559 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
…-analytics-dashboards-plugin into add_finding_flyout_loading_state
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #562 +/- ##
==========================================
- Coverage 32.55% 32.49% -0.07%
==========================================
Files 136 136
Lines 4076 4084 +8
Branches 664 666 +2
==========================================
Hits 1327 1327
- Misses 2609 2617 +8
Partials 140 140 |
amsiglan
approved these changes
May 3, 2023
…-analytics-dashboards-plugin into add_finding_flyout_loading_state # Conflicts: # public/pages/Findings/components/FindingDetailsFlyout.tsx
…-analytics-dashboards-plugin into add_finding_flyout_loading_state # Conflicts: # cypress/integration/1_detectors.spec.js
…-analytics-dashboards-plugin into add_finding_flyout_loading_state
getsaurabh02
approved these changes
May 4, 2023
getsaurabh02
approved these changes
May 4, 2023
amsiglan
pushed a commit
to amsiglan/security-analytics-dashboards-plugin
that referenced
this pull request
May 5, 2023
* [FEATURE] Set loading state for finding fly-out until the data is ready opensearch-project#559 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * fix tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * fix tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
1 task
amsiglan
added a commit
that referenced
this pull request
May 5, 2023
…577) * [BUG] Finding's fly-out has no correlations if open from alerts (#558) * [BUG] Finding's fly-out has no correlations if open from alerts #557 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * code review from #558 (comment) Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests wait interval updated to 400 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests wait interval updated to 400 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress | create detector specs update (#518) * [FEATURE] Create global state object for async requests #491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests #491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests #491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests #491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests #491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests #491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests #491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests #491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests #491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests #491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Provide empty states for Findings and Alerts page #471 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature #495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests #493 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests #493 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor alert triggers per mocks #498 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests #493 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests #493 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor alert triggers per mocks #498 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor alert triggers per mocks #498 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Update detector details component #502 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Update detector details component #502 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Update detector details component #502 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Update detector details component #502 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Feature] update detector details component #504 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Feature] update detector details component #504 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Update detector details component #504 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] No space between the detector details and the rule panel #522 [BUG] A rule flyout without references have an empty link #521 [FEATURE] Update header size to use euiTitle--small #520 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] No space between the detector details and the rule panel #522 [BUG] A rule flyout without references have an empty link #521 [FEATURE] Update header size to use euiTitle--small #520 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * refactored util methods into cypress commands Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * refactored util methods into cypress commands Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests wait interval updated to 400 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * added link to rules; simplified rule parsing (#571) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * [FEATURE] Finding flyout loading state (#562) * [FEATURE] Set loading state for finding fly-out until the data is ready #559 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * fix tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * fix tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add correlation rule details into the finding details flyout #563 (#565) * Add correlation rule details into the finding details flyout #563 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add correlation rule details into the finding details flyout #563 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * fix tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add correlation rule details into the finding details flyout #563 #565 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add correlation rule details into the finding details flyout #563 #565 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add correlation rule details into the finding details flyout #563 #565 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * UX improvements for correlation engine (#561) * passing props for date time filter (#551) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * added loading state Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * ux improvements Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * transform vega-lite files for jest testing Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Add a details button to open the findings flyout from the correlations page. (#572) * Add a details button to open the findings flyout from the correlations page. #564 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add a details button to open the findings flyout from the correlations page. #564 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Add a details button to open the findings flyout from the correlations page. #564 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * fix tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] Wrong field mappings for the cloud trail logs #573 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Wrong field mappings for the cloud trail logs (#574) * Wrong field mappings for the cloud trail logs #573 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] Wrong field mappings for the cloud trail logs #573 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] Wrong field mappings for the cloud trail logs #573 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated workflow file Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated osd branch for cypress tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…pensearch-project#577) * [BUG] Finding's fly-out has no correlations if open from alerts (opensearch-project#558) * [BUG] Finding's fly-out has no correlations if open from alerts opensearch-project#557 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * code review from opensearch-project#558 (comment) Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests wait interval updated to 400 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests wait interval updated to 400 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress | create detector specs update (opensearch-project#518) * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#491 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Provide empty states for Findings and Alerts page opensearch-project#471 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#493 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#493 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#493 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create global state object for async requests opensearch-project#493 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Update detector details component opensearch-project#502 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Update detector details component opensearch-project#502 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Update detector details component opensearch-project#502 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Update detector details component opensearch-project#502 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Feature] update detector details component opensearch-project#504 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Feature] update detector details component opensearch-project#504 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Update detector details component opensearch-project#504 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] No space between the detector details and the rule panel opensearch-project#522 [BUG] A rule flyout without references have an empty link opensearch-project#521 [FEATURE] Update header size to use euiTitle--small opensearch-project#520 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] No space between the detector details and the rule panel opensearch-project#522 [BUG] A rule flyout without references have an empty link opensearch-project#521 [FEATURE] Update header size to use euiTitle--small opensearch-project#520 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated create detectors cypress specs Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * refactored util methods into cypress commands Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * refactored util methods into cypress commands Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * cypress tests wait interval updated to 400 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * added link to rules; simplified rule parsing (opensearch-project#571) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * [FEATURE] Finding flyout loading state (opensearch-project#562) * [FEATURE] Set loading state for finding fly-out until the data is ready opensearch-project#559 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * fix tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * fix tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add correlation rule details into the finding details flyout opensearch-project#563 (opensearch-project#565) * Add correlation rule details into the finding details flyout opensearch-project#563 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add correlation rule details into the finding details flyout opensearch-project#563 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * fix tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * UX improvements for correlation engine (opensearch-project#561) * passing props for date time filter (opensearch-project#551) Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * added loading state Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * ux improvements Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * transform vega-lite files for jest testing Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * Add a details button to open the findings flyout from the correlations page. (opensearch-project#572) * Add a details button to open the findings flyout from the correlations page. opensearch-project#564 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Add a details button to open the findings flyout from the correlations page. opensearch-project#564 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [FEATURE] Add a details button to open the findings flyout from the correlations page. opensearch-project#564 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * fix tests Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * Wrong field mappings for the cloud trail logs (opensearch-project#574) * Wrong field mappings for the cloud trail logs opensearch-project#573 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573 Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * code review Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> * updated workflow file Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> * updated osd branch for cypress tests Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> --------- Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com> Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set the loading state for finding fly-out until the data is ready
Issues Resolved
Resolves #559
Screenshots
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.