Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] PRs for correlation engine and minor UX improvements #577

Merged
merged 10 commits into from
May 5, 2023

Conversation

amsiglan
Copy link
Collaborator

@amsiglan amsiglan commented May 5, 2023

Description

Backports below PRs to 2.x branch
#558
#518
#571
#562
#565
#561
#572
#574

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@amsiglan amsiglan requested a review from a team May 5, 2023 17:23
jovancacvetkovic and others added 8 commits May 5, 2023 10:31
…search-project#558)

* [BUG] Finding's fly-out has no correlations if open from alerts opensearch-project#557

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review from opensearch-project#558 (comment)

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Provide empty states for Findings and Alerts page opensearch-project#471

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Feature] update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Feature] update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
* [FEATURE] Set loading state for finding fly-out until the data is ready opensearch-project#559

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* fix tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* fix tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
…ch-project#563 (opensearch-project#565)

* Add correlation rule details into the finding details flyout opensearch-project#563

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add correlation rule details into the finding details flyout opensearch-project#563

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* fix tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
* passing props for date time filter (opensearch-project#551)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* added loading state

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* ux improvements

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* transform vega-lite files for jest testing

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

---------

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
…s page. (opensearch-project#572)

* Add a details button to open the findings flyout from the correlations page. opensearch-project#564

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add a details button to open the findings flyout from the correlations page. opensearch-project#564

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Add a details button to open the findings flyout from the correlations page. opensearch-project#564

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* fix tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
* Wrong field mappings for the cloud trail logs opensearch-project#573

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2023

Codecov Report

Merging #577 (df0ec51) into 2.x (f93dfe0) will decrease coverage by 0.21%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              2.x     #577      +/-   ##
==========================================
- Coverage   32.66%   32.45%   -0.21%     
==========================================
  Files         135      137       +2     
  Lines        4020     4126     +106     
  Branches      697      677      -20     
==========================================
+ Hits         1313     1339      +26     
- Misses       2567     2648      +81     
+ Partials      140      139       -1     

see 24 files with indirect coverage changes

@amsiglan amsiglan changed the title [Backport 2.x] cypress | create detector specs update (#518) [Backport 2.x] PRs for correlation engine and minor UX improvements May 5, 2023
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
@amsiglan amsiglan merged commit 26aa359 into opensearch-project:2.x May 5, 2023
7 checks passed
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…pensearch-project#577)

* [BUG] Finding's fly-out has no correlations if open from alerts (opensearch-project#558)

* [BUG] Finding's fly-out has no correlations if open from alerts opensearch-project#557

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review from opensearch-project#558 (comment)

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress | create detector specs update (opensearch-project#518)

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#491

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Provide empty states for Findings and Alerts page opensearch-project#471

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor and move field mapping to first the page of create detector feature opensearch-project#495

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create global state object for async requests opensearch-project#493

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Create detector \ Refactor alert triggers per mocks opensearch-project#498

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Update detector details component opensearch-project#502

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Feature] update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Feature] update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Update detector details component opensearch-project#504

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] No space between the detector details and the rule panel opensearch-project#522
[BUG] A rule flyout without references have an empty link opensearch-project#521
[FEATURE] Update header size to use euiTitle--small opensearch-project#520

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated create detectors cypress specs

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* refactored util methods into cypress commands

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* cypress tests wait interval updated to 400

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* added link to rules; simplified rule parsing (opensearch-project#571)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* [FEATURE] Finding flyout loading state (opensearch-project#562)

* [FEATURE] Set loading state for finding fly-out until the data is ready opensearch-project#559

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* fix tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* fix tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add correlation rule details into the finding details flyout opensearch-project#563 (opensearch-project#565)

* Add correlation rule details into the finding details flyout opensearch-project#563

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add correlation rule details into the finding details flyout opensearch-project#563

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* fix tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add correlation rule details into the finding details flyout opensearch-project#563 opensearch-project#565

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* UX improvements for correlation engine (opensearch-project#561)

* passing props for date time filter (opensearch-project#551)

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* added loading state

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* ux improvements

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* transform vega-lite files for jest testing

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

---------

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* Add a details button to open the findings flyout from the correlations page. (opensearch-project#572)

* Add a details button to open the findings flyout from the correlations page. opensearch-project#564

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Add a details button to open the findings flyout from the correlations page. opensearch-project#564

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [FEATURE] Add a details button to open the findings flyout from the correlations page. opensearch-project#564

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* fix tests

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* Wrong field mappings for the cloud trail logs (opensearch-project#574)

* Wrong field mappings for the cloud trail logs opensearch-project#573

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* [BUG] Wrong field mappings for the cloud trail logs opensearch-project#573

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* code review

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>

* updated workflow file

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

* updated osd branch for cypress tests

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>

---------

Signed-off-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Co-authored-by: Jovan Cvetkovic <jovanca.cvetkovic@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants