Fix duplicate ecs mappings which returns incorrect log index field in mapping view API (#786)

[jowg-amazon]

Description

An ecs field may have multiple raw fields associated with it. Currently, in the getMappingsView api, the ecs field will only map to one raw field. The new implementation will automatically map the ecs field to whatever field is present in the index. If multiple raw fields are present in an index, it will automatically map to one of the raw fields and add the other(s) into the unmappedIndexFields list.

This PR also removes duplicates from the unmappedFieldAliases list.

Issues Resolved

#786

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[amsiglan]

This is same as the if case. Not sure how it would work differently.

[jowg-amazon]

The first if clause checks if the alias mapping fields already contains the ecs key, if it's true then it checks to make sure that the raw field path that we want to insert is consistent with the one in pathsOfApplyableAliases. If it's not consistent, then we skip and do not override the mapping. If the key doesn't exist in the map in the first place, then we directly insert the mapping.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 24.80%. Comparing base (8ef0a3f) to head (1a2c07b).

Files	Patch %	Lines
...search/securityanalytics/mapper/MapperService.java	0.00%	16 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #788      +/-   ##
============================================
- Coverage     24.82%   24.80%   -0.02%     
  Complexity     1030     1030              
============================================
  Files           277      277              
  Lines         12717    12727      +10     
  Branches       1401     1404       +3     
============================================
  Hits           3157     3157              
- Misses         9296     9306      +10     
  Partials        264      264              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[engechas]

Minor: we're already very nested here, we could create a private method to handle this logic rather than nesting further

[jowg-amazon]

refactored out the method for better readability

[eirsep]

nit alway write this condition as false == <boolean> for quicker readability and less confusion

[jowg-amazon]

done

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-788-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 689760e897294530dea0d1181c2539e9b607d23c
# Push it to GitHub
git push --set-upstream origin backport/backport-788-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-788-to-2.x.

[opensearch-trigger-bot]

The backport to 2.9 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.9 2.9
# Navigate to the new working tree
cd .worktrees/backport-2.9
# Create a new branch
git switch --create backport/backport-788-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 689760e897294530dea0d1181c2539e9b607d23c
# Push it to GitHub
git push --set-upstream origin backport/backport-788-to-2.9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.9

Then, create a pull request where the base branch is 2.9 and the compare/head branch is backport/backport-788-to-2.9.

[opensearch-trigger-bot]

The backport to 2.5 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.5 2.5
# Navigate to the new working tree
cd .worktrees/backport-2.5
# Create a new branch
git switch --create backport/backport-788-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 689760e897294530dea0d1181c2539e9b607d23c
# Push it to GitHub
git push --set-upstream origin backport/backport-788-to-2.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.5

Then, create a pull request where the base branch is 2.5 and the compare/head branch is backport/backport-788-to-2.5.

[opensearch-trigger-bot]

The backport to 2.11 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.11 2.11
# Navigate to the new working tree
cd .worktrees/backport-2.11
# Create a new branch
git switch --create backport/backport-788-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 689760e897294530dea0d1181c2539e9b607d23c
# Push it to GitHub
git push --set-upstream origin backport/backport-788-to-2.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.11

Then, create a pull request where the base branch is 2.11 and the compare/head branch is backport/backport-788-to-2.11.

[opensearch-trigger-bot]

The backport to 2.7 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.7 2.7
# Navigate to the new working tree
cd .worktrees/backport-2.7
# Create a new branch
git switch --create backport/backport-788-to-2.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 689760e897294530dea0d1181c2539e9b607d23c
# Push it to GitHub
git push --set-upstream origin backport/backport-788-to-2.7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.7

Then, create a pull request where the base branch is 2.7 and the compare/head branch is backport/backport-788-to-2.7.