Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport changes and Integ test fix #935

Merged
merged 5 commits into from
Mar 16, 2024
Merged

Backport changes and Integ test fix #935

merged 5 commits into from
Mar 16, 2024

Conversation

riysaxen-amzn
Copy link
Collaborator

@riysaxen-amzn riysaxen-amzn commented Mar 16, 2024

Description

  • Backport changes and
  • Fixes the CI failures by fixingAggregationBackendTests -> testCloudtrailAggregationRule and testCountAggregationWithGroupBy

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

jowg-amazon and others added 5 commits March 13, 2024 02:51
… mapping view API (#786) (#788)

* field mapping changes

Signed-off-by: Joanne Wang <jowg@amazon.com>

* add integ test

Signed-off-by: Joanne Wang <jowg@amazon.com>

* turn unmappedfieldaliases as set and add integ test

Signed-off-by: Joanne Wang <jowg@amazon.com>

* add comments

Signed-off-by: Joanne Wang <jowg@amazon.com>

* fix integ tests

Signed-off-by: Joanne Wang <jowg@amazon.com>

* moved logic to method for better readability

Signed-off-by: Joanne Wang <jowg@amazon.com>

---------

Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
…emove blocking actionGet() calls (#873)

* pass query field names in doc level queries during monitor creation/updation

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* remove actionGet() and change get index mapping call to event driven flow

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* fix chained findings monitor

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* add finding mappings

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* remove test messages from logs

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* revert build.gradle change

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

---------

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Signed-off-by: Riya Saxena <riysaxen@amazon.com>
@riysaxen-amzn riysaxen-amzn changed the title Integ test fix Backport changes and Integ test fix Mar 16, 2024
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 7.27969% with 242 lines in your changes are missing coverage. Please review.

Project coverage is 25.66%. Comparing base (7fbe7c0) to head (d5f44f7).

Files Patch % Lines
...lytics/transport/TransportIndexDetectorAction.java 0.00% 220 Missing ⚠️
...search/securityanalytics/mapper/MapperService.java 0.00% 22 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.9     #935      +/-   ##
============================================
- Coverage     25.72%   25.66%   -0.07%     
- Complexity      941      950       +9     
============================================
  Files           252      252              
  Lines         10754    10854     +100     
  Branches       1199     1204       +5     
============================================
+ Hits           2767     2786      +19     
- Misses         7739     7824      +85     
+ Partials        248      244       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@praveensameneni praveensameneni merged commit e44e5d4 into 2.9 Mar 16, 2024
11 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants