Pass rule field names in doc level queries during monitor/creation. Remove blocking actionGet() calls #873

eirsep · 2024-02-27T22:22:28Z

Description

Pass rule field names in doc level queries during monitor/creation. This utilizes optimization done in alerting to avoid fetching entire _source of docs in doc level monitor

Issues Resolved

opensearch-project/alerting#1367

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

engechas

Small comments, rest LGTM

engechas · 2024-02-28T22:02:15Z

build.gradle

@@ -158,7 +158,7 @@ dependencies {
    implementation group: 'org.apache.commons', name: 'commons-lang3', version: "${versions.commonslang}"
    implementation "org.antlr:antlr4-runtime:4.10.1"
    implementation "com.cronutils:cron-utils:9.1.6"
-    api "org.opensearch:common-utils:${common_utils_version}@jar"
+    api files("/Users/snistala/Documents/opensearch/common-utils/build/libs/common-utils-3.0.0.0-SNAPSHOT.jar")


Accidental change

engechas · 2024-02-28T22:02:45Z

src/main/java/org/opensearch/securityanalytics/mapper/MapperService.java

@@ -92,6 +94,7 @@ public void onResponse(GetMappingsResponse getMappingsResponse) {
                applyAliasMappings(getMappingsResponse.getMappings(), logType, aliasMappings, partial, new ActionListener<>() {
                    @Override
                    public void onResponse(Collection<CreateMappingResult> createMappingResponse) {
+                        log.error("PERF_DEBUG_SAP: Completed create mappings for {}", indexName);


We should change this to debug and remove the PERF_DEBUG_SAP prefix

engechas · 2024-02-28T22:03:00Z

src/main/java/org/opensearch/securityanalytics/mapper/MapperService.java

@@ -110,6 +113,7 @@ public void onResponse(Collection<CreateMappingResult> createMappingResponse) {

                    @Override
                    public void onFailure(Exception e) {
+                        log.error("PERF_DEBUG_SAP: Failed to create mappings for {}", indexName );


Same as above, though this one could stay as error

engechas · 2024-02-28T22:03:43Z

src/main/java/org/opensearch/securityanalytics/transport/TransportIndexDetectorAction.java

@@ -220,19 +222,22 @@ private void checkIndicesAndExecute(
        ActionListener<IndexDetectorResponse> listener,
        User user
    ) {
+        log.error("PERF_DEBUG_SAP: check indices and execute began");


Same as above and throughout this file

…pdation Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

…flow Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

codecov · 2024-03-05T22:50:28Z

Codecov Report

Attention: Patch coverage is 1.95122% with 201 lines in your changes are missing coverage. Please review.

Project coverage is 24.63%. Comparing base (172d58d) to head (6715552).
Report is 1 commits behind head on main.

Files	Patch %	Lines
...lytics/transport/TransportIndexDetectorAction.java	0.00%	196 Missing ⚠️
...search/securityanalytics/mapper/MapperService.java	0.00%	5 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #873      +/-   ##
============================================
- Coverage     24.79%   24.63%   -0.16%     
- Complexity     1026     1030       +4     
============================================
  Files           277      277              
  Lines         12702    12817     +115     
  Branches       1394     1393       -1     
============================================
+ Hits           3149     3158       +9     
- Misses         9288     9395     +107     
+ Partials        265      264       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

engechas · 2024-03-05T23:26:56Z

src/test/java/org/opensearch/securityanalytics/resthandler/DetectorMonitorRestApiIT.java

@@ -2056,7 +2056,7 @@ public void testCreateDetectorWithCloudtrailAggrRuleWithEcsFields() throws IOExc
        // both req params and req body are supported
        createMappingRequest.setJsonEntity(
                "{\n" +
-                        "  \"index_name\": \"" + index + "\",\n" +
+                        "  \"index_name\": \"cloudtrail\",\n" +


This should still be a variable, right?

engechas · 2024-03-05T23:27:13Z

src/test/java/org/opensearch/securityanalytics/alerts/AlertingServiceTests.java

@@ -1,322 +0,0 @@
-/*


What's the reason to delete this file?

twas unintentional.
reverted.
thanks for flagging this.

riysaxen-amzn

could we rename the PR description to Pass rule field names in doc level queries during monitor update/creation. ?

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

eirsep · 2024-03-06T10:06:02Z

could we rename the PR description to Pass rule field names in doc level queries during monitor update/creation. ?

The blocking call removals is also a key fix as that has caused create/update API to get stuck without response. I would prefer retaining it. Open to discuss further if you feel otherwise

Comment about PR name

opensearch-trigger-bot · 2024-03-07T10:03:28Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-873-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 887739066de2d636d008711f12eec226d2b935b1
# Push it to GitHub
git push --set-upstream origin backport/backport-873-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-873-to-2.x.

…emove blocking actionGet() calls (opensearch-project#873) * pass query field names in doc level queries during monitor creation/updation Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * remove actionGet() and change get index mapping call to event driven flow Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix chained findings monitor Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * add finding mappings Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * remove test messages from logs Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * revert build.gradle change Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* support object fields in aggregation based sigma rules (#789) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * Pass rule field names in doc level queries during monitor/creation. Remove blocking actionGet() calls (#873) * pass query field names in doc level queries during monitor creation/updation Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * remove actionGet() and change get index mapping call to event driven flow Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix chained findings monitor Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * add finding mappings Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * remove test messages from logs Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * revert build.gradle change Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com>

Signed-off-by: Joanne Wang <jowg@amazon.com> (cherry picked from commit 4d4f5e3) Co-authored-by: Joanne Wang <jowg@amazon.com> Reduce log level for informative message (opensearch-project#203) (opensearch-project#833) Signed-off-by: Enrico Tröger <enrico.troeger@uvena.de> Co-authored-by: Enrico Tröger <enrico.troeger@uvena.de> Updated alert creation following common-utils PR 584. (opensearch-project#837) (opensearch-project#839) Signed-off-by: AWSHurneyt <hurneyt@amazon.com> (cherry picked from commit 8adb9c3) Co-authored-by: AWSHurneyt <hurneyt@amazon.com> Release notes for 2.12.0 (opensearch-project#834) (opensearch-project#841) * release notes for 2.12 Signed-off-by: Joanne Wang <jowg@amazon.com> * update release notes Signed-off-by: Joanne Wang <jowg@amazon.com> * update release notes Signed-off-by: Joanne Wang <jowg@amazon.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com> (cherry picked from commit 414484a) Co-authored-by: Joanne Wang <jowg@amazon.com> Remove blocking calls and change threat intel feed flow to event driven (opensearch-project#871) (opensearch-project#876) * remove actionGet() and change threat intel feed flow to event driven Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix javadocs Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * revert try catch removals Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * use action listener wrap() in detector threat intel code paths Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * add try catch Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> (cherry picked from commit 172d58d) Co-authored-by: Surya Sashank Nistala <snistala@amazon.com> Fail the flow the when detectot type is missing in the log types index (opensearch-project#845) (opensearch-project#857) Signed-off-by: Megha Goyal <goyamegh@amazon.com> (cherry picked from commit 8d19912) Co-authored-by: Megha Goyal <56077967+goyamegh@users.noreply.github.com> [BUG] ArrayIndexOutOfBoundsException for inconsistent detector index behavior (opensearch-project#843) (opensearch-project#858) * Catch ArrayIndexOutOfBoundsException when detector is missing Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Add a check on SearchHits.getHits() length Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Remove index out of bounds exception Signed-off-by: Megha Goyal <goyamegh@amazon.com> --------- Signed-off-by: Megha Goyal <goyamegh@amazon.com> (cherry picked from commit 0ef8543) Co-authored-by: Megha Goyal <56077967+goyamegh@users.noreply.github.com> Backport opensearch-project#873 and opensearch-project#789 (opensearch-project#895) * support object fields in aggregation based sigma rules (opensearch-project#789) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * Pass rule field names in doc level queries during monitor/creation. Remove blocking actionGet() calls (opensearch-project#873) * pass query field names in doc level queries during monitor creation/updation Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * remove actionGet() and change get index mapping call to event driven flow Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix chained findings monitor Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * add finding mappings Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * remove test messages from logs Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * revert build.gradle change Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> Fix duplicate ecs mappings which returns incorrect log index field in mapping view API (opensearch-project#786) (opensearch-project#788) (opensearch-project#898) * field mapping changes * add integ test * turn unmappedfieldaliases as set and add integ test * add comments * fix integ tests * moved logic to method for better readability --------- Signed-off-by: Joanne Wang <jowg@amazon.com> Add throw for empty strings in rules with modifier contains, startwith, and endswith (opensearch-project#860) (opensearch-project#896) * add validation for empty strings with contains, startswith and endswith modifiers * throw exception if empty string with contains, startswith, or endswith * change var name * add modifiers to log --------- Signed-off-by: Joanne Wang <jowg@amazon.com> Add an "exists" check for "not" condition in sigma rules (opensearch-project#852) (opensearch-project#897) * test design Signed-off-by: Joanne Wang <jowg@amazon.com> * working version Signed-off-by: Joanne Wang <jowg@amazon.com> * cleaning up Signed-off-by: Joanne Wang <jowg@amazon.com> * testing Signed-off-by: Joanne Wang <jowg@amazon.com> * working version Signed-off-by: Joanne Wang <jowg@amazon.com> * working version Signed-off-by: Joanne Wang <jowg@amazon.com> * refactored querybackend Signed-off-by: Joanne Wang <jowg@amazon.com> * working on tests Signed-off-by: Joanne Wang <jowg@amazon.com> * fixed alerting and finding tests Signed-off-by: Joanne Wang <jowg@amazon.com> * fix correlation tests Signed-off-by: Joanne Wang <jowg@amazon.com> * working all tests Signed-off-by: Joanne Wang <jowg@amazon.com> * moved test and changed alias for adldap Signed-off-by: Joanne Wang <jowg@amazon.com> * added more tests Signed-off-by: Joanne Wang <jowg@amazon.com> * cleanup code Signed-off-by: Joanne Wang <jowg@amazon.com> * remove exists flag Signed-off-by: Joanne Wang <jowg@amazon.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com> (cherry picked from commit 656a5fe) Co-authored-by: Joanne Wang <jowg@amazon.com> Add goyamegh as a maintainer (opensearch-project#868) (opensearch-project#899) Signed-off-by: Megha Goyal <goyamegh@amazon.com> Refactor invocation of Action listeners in correlations (opensearch-project#880) (opensearch-project#900) * Refactor invocation of Action listeners in correlations * Close hanging tasks in correlations workflow * Logging finding id and monitor id in error logs --------- Signed-off-by: Megha Goyal <goyamegh@amazon.com> Add search request timeouts for correlations workflows (opensearch-project#893) (opensearch-project#901) * Reinstating more leaks plugged-in for correlations workflows Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Add search timeouts to all correlation searches Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Fix logging and exception messages Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Change search timeout to 30 seconds Signed-off-by: Megha Goyal <goyamegh@amazon.com> --------- Signed-off-by: Megha Goyal <goyamegh@amazon.com> (cherry picked from commit 75c4429) Co-authored-by: Megha Goyal <56077967+goyamegh@users.noreply.github.com>

Signed-off-by: Chase Engelbrecht <engechas@amazon.com>

…emove blocking actionGet() calls (opensearch-project#873) * pass query field names in doc level queries during monitor creation/updation Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * remove actionGet() and change get index mapping call to event driven flow Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix chained findings monitor Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * add finding mappings Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * remove test messages from logs Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * revert build.gradle change Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* query_field_names bugfix (#335) Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> * Reduce log level for informative message (#203) Signed-off-by: Enrico Tröger <enrico.troeger@uvena.de> * fix detector writeTo() method missing fields (#695) * fix detector writeTo() method missing fields Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix test Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix null query filter conversion from sigma to query string query (#722) * fix null query filter conversion from sigma to query string query Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix rule to query conversion tests for null filter Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * enhance test to verify non null doc doesnt match null query Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * Bump version 2.5.1, fix build Signed-off-by: Chase Engelbrecht <engechas@amazon.com> * Manual cherry-pick of #873 Signed-off-by: Chase Engelbrecht <engechas@amazon.com> * Fix miss from manual cherry-pick Signed-off-by: Chase Engelbrecht <engechas@amazon.com> * Undo exceptional case not originally present Signed-off-by: Chase Engelbrecht <engechas@amazon.com> * Revert test from previous commit reversion Signed-off-by: Chase Engelbrecht <engechas@amazon.com> * Fix another miss from manual cherry-pick Signed-off-by: Chase Engelbrecht <engechas@amazon.com> * Revert behavior for no rules in detector Signed-off-by: Chase Engelbrecht <engechas@amazon.com> --------- Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com> Signed-off-by: Enrico Tröger <enrico.troeger@uvena.de> Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> Signed-off-by: Chase Engelbrecht <engechas@amazon.com> Co-authored-by: Petar Dzepina <petar.dzepina@gmail.com> Co-authored-by: Enrico Tröger <enrico.troeger@uvena.de> Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>

…emove blocking actionGet() calls (opensearch-project#873) * pass query field names in doc level queries during monitor creation/updation Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * remove actionGet() and change get index mapping call to event driven flow Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix chained findings monitor Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * add finding mappings Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * remove test messages from logs Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * revert build.gradle change Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

* Fix duplicate ecs mappings which returns incorrect log index field in mapping view API (#786) (#788) * field mapping changes Signed-off-by: Joanne Wang <jowg@amazon.com> * add integ test Signed-off-by: Joanne Wang <jowg@amazon.com> * turn unmappedfieldaliases as set and add integ test Signed-off-by: Joanne Wang <jowg@amazon.com> * add comments Signed-off-by: Joanne Wang <jowg@amazon.com> * fix integ tests Signed-off-by: Joanne Wang <jowg@amazon.com> * moved logic to method for better readability Signed-off-by: Joanne Wang <jowg@amazon.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com> * support object fields in aggregation based sigma rules (#789) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> * Pass rule field names in doc level queries during monitor/creation. Remove blocking actionGet() calls (#873) * pass query field names in doc level queries during monitor creation/updation Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * remove actionGet() and change get index mapping call to event driven flow Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix chained findings monitor Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * add finding mappings Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * remove test messages from logs Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * revert build.gradle change Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * version bump Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * AggregationBackendTests fix Signed-off-by: Riya Saxena <riysaxen@amazon.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com> Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> Signed-off-by: Riya Saxena <riysaxen@amazon.com> Co-authored-by: Joanne Wang <jowg@amazon.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> Co-authored-by: Surya Sashank Nistala <snistala@amazon.com>

* Version bump to 2.7.1 Signed-off-by: Megha Goyal <goyamegh@amazon.com> * fix detector writeTo() method missing fields (#695) * fix detector writeTo() method missing fields Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix test Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix null query filter conversion from sigma to query string query (#722) * fix null query filter conversion from sigma to query string query Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix rule to query conversion tests for null filter Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * enhance test to verify non null doc doesnt match null query Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * * #709 Return empty response for empty mappings and no applied aliases Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Adding integ tests for empty mappings/aliases use-cases Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Fix unit tests for MappingsTraverser Signed-off-by: Megha Goyal <goyamegh@amazon.com> --------- Signed-off-by: Megha Goyal <goyamegh@amazon.com> * fixing build failures for previous cherry-pick PR for SAP2.7 (to be squashed) Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * Pass rule field names in doc level queries during monitor/creation. Remove blocking actionGet() calls (#873) * pass query field names in doc level queries during monitor creation/updation Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * remove actionGet() and change get index mapping call to event driven flow Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fix chained findings monitor Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * add finding mappings Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * remove test messages from logs Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * revert build.gradle change Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> --------- Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> * fixing an import Signed-off-by: Dennis Toepker <toepkerd@amazon.com> --------- Signed-off-by: Megha Goyal <goyamegh@amazon.com> Signed-off-by: Surya Sashank Nistala <snistala@amazon.com> Signed-off-by: Dennis Toepker <toepkerd@amazon.com> Co-authored-by: Megha Goyal <goyamegh@amazon.com> Co-authored-by: Surya Sashank Nistala <snistala@amazon.com> Co-authored-by: Megha Goyal <56077967+goyamegh@users.noreply.github.com> Co-authored-by: Dennis Toepker <toepkerd@amazon.com>

eirsep requested review from amsiglan, AWSHurneyt, getsaurabh02, lezzago, praveensameneni, sbcd90, jowg-amazon, engechas, goyamegh and riysaxen-amzn as code owners February 27, 2024 22:22

engechas reviewed Feb 28, 2024

View reviewed changes

eirsep force-pushed the qfn branch from 6e33100 to a04916a Compare March 2, 2024 01:49

eirsep added 5 commits March 5, 2024 11:21

pass query field names in doc level queries during monitor creation/u…

61e8b15

…pdation Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

remove actionGet() and change get index mapping call to event driven …

b09396e

…flow Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

fix chained findings monitor

4130b49

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

add finding mappings

66658e8

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

remove test messages from logs

d9789ae

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

eirsep force-pushed the qfn branch 2 times, most recently from 3dc8d37 to 56c07ea Compare March 5, 2024 22:34

engechas reviewed Mar 5, 2024

View reviewed changes

riysaxen-amzn previously requested changes Mar 6, 2024

View reviewed changes

engechas previously approved these changes Mar 6, 2024

View reviewed changes

revert build.gradle change

6715552

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>

eirsep dismissed engechas’s stale review via 6715552 March 6, 2024 10:04

eirsep force-pushed the qfn branch from 56c07ea to 6715552 Compare March 6, 2024 10:04

engechas approved these changes Mar 6, 2024

View reviewed changes

sbcd90 approved these changes Mar 6, 2024

View reviewed changes

eirsep merged commit 8877390 into opensearch-project:main Mar 6, 2024
7 of 18 checks passed

eirsep added the backport 2.x label Mar 7, 2024

eirsep mentioned this pull request Mar 8, 2024

Backport #874, #860, #873 to 2.x #894

Closed

eirsep mentioned this pull request Mar 8, 2024

Backport #873 and #789 #895

Merged

engechas added a commit to engechas/security-analytics that referenced this pull request Mar 14, 2024

Manual cherry-pick of opensearch-project#873

f2a78b5

Signed-off-by: Chase Engelbrecht <engechas@amazon.com>

engechas mentioned this pull request Mar 15, 2024

Backports for 2.5 #927

Merged

5 tasks

eirsep mentioned this pull request Mar 15, 2024

Pass rule field names in doc level queries during monitor/creation. R… goyamegh/security-analytics#2

Closed

5 tasks

toepkerd mentioned this pull request Mar 19, 2024

Security Analytics 2.7 Backports #938

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pass rule field names in doc level queries during monitor/creation. Remove blocking actionGet() calls #873

Pass rule field names in doc level queries during monitor/creation. Remove blocking actionGet() calls #873

eirsep commented Feb 27, 2024

engechas left a comment

engechas Feb 28, 2024

engechas Feb 28, 2024

engechas Feb 28, 2024

engechas Feb 28, 2024

codecov bot commented Mar 5, 2024 •

edited

Loading

engechas Mar 5, 2024

eirsep Mar 6, 2024

engechas Mar 5, 2024

eirsep Mar 6, 2024

riysaxen-amzn left a comment

eirsep commented Mar 6, 2024

opensearch-trigger-bot bot commented Mar 7, 2024

Pass rule field names in doc level queries during monitor/creation. Remove blocking actionGet() calls #873

Pass rule field names in doc level queries during monitor/creation. Remove blocking actionGet() calls #873

Conversation

eirsep commented Feb 27, 2024

Description

Issues Resolved

Check List

engechas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Mar 5, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

riysaxen-amzn left a comment

Choose a reason for hiding this comment

eirsep commented Mar 6, 2024

opensearch-trigger-bot bot commented Mar 7, 2024

codecov bot commented Mar 5, 2024 •

edited

Loading