This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 277
Kubernetes probe rewriting doesn't handle multiple containers with the same probe type #3773
Comments
This issue will be closed due to a long period of inactivity. If you would like this issue to remain open then please comment or update. |
Issue closed due to inactivity. |
#4558 resolves part of this issue. Supported Scenario:
|
This issue will be closed due to a long period of inactivity. If you would like this issue to remain open then please comment or update. |
Issue closed due to inactivity. |
Issue closed due to inactivity. |
Issue closed due to inactivity. |
Issue closed due to inactivity. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Bug description: When a Pod has two containers each with a liveness probe, the osm-injector rewrites both probes to
/osm-liveness-probe
on port 15901. However, the Envoy cluster configured for liveness probes only contains one endpoint, so probes from the kubelet are all directed only to one of the probes. This may hide probe failures if another container's probe of the same type is succeeding.Affected area (please mark with X where applicable):
Expected behavior: Probes from the kubelet are routed by Envoy to the correct container.
Steps to reproduce the bug (as precisely as possible):
Roughly, create a Pod with two containers, each with a readinessProbe. The first probe fails when the Pod is not injected with a sidecar (as it should) and passes erroneously when it is injected with a sidecar.
Here are copy-paste steps to reproduce (assuming
kind
is installed). The finalkubectl wait
should fail, but succeeds:You can also inspect the container logs to see only the second container is responding to any probes:
The full envoy config for the pod:
How was OSM installed?: as above, CLI and default install besides images built from source
Anything else we need to know?:
Environment:
osm version
):kubectl version
):The text was updated successfully, but these errors were encountered: