Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.13] wathola receiver, annotate span by step number #528

Open
wants to merge 1 commit into
base: release-v1.12
Choose a base branch
from

Conversation

maschmid
Copy link

backports knative#7667

@openshift-ci openshift-ci bot requested review from aliok and lberk February 12, 2024 11:38
@maschmid
Copy link
Author

/cherry-pick release-v1.12

@openshift-cherrypick-robot

@maschmid: once the present PR merges, I will cherry-pick it on top of release-v1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maschmid
Copy link
Author

/cherry-pick release-v1.11

@openshift-cherrypick-robot

@maschmid: once the present PR merges, I will cherry-pick it on top of release-v1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maschmid
Copy link
Author

/retest-required

@creydr
Copy link
Member

creydr commented Feb 20, 2024

@maschmid we fixed a couple of issues in 1.13 (which lead to some CI failures). Can you rebase this PR?

@maschmid maschmid force-pushed the maschmid-release-v1.13-backport-receiver-trace-step-annotation branch from 392546d to 61cffda Compare February 20, 2024 16:43
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, maschmid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8536839 and 2 for PR HEAD 61cffda in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 893e61c and 1 for PR HEAD 61cffda in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b1920de and 0 for PR HEAD 61cffda in total

@openshift-ci-robot
Copy link

/hold

Revision 61cffda was retested 3 times: holding

@matzew
Copy link
Member

matzew commented Feb 27, 2024

/retest

1 similar comment
@pierDipi
Copy link
Member

/retest

@matzew
Copy link
Member

matzew commented Mar 4, 2024

/unhold

@matzew
Copy link
Member

matzew commented Mar 4, 2024

/retest

not sure why now all fail, after all was green ....

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c2534b2 and 2 for PR HEAD 61cffda in total

@maschmid
Copy link
Author

maschmid commented Mar 4, 2024

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 15e55a4 and 1 for PR HEAD 61cffda in total

@creydr
Copy link
Member

creydr commented Mar 4, 2024

"origin-operator-registry:4.15" is invalid: from: Error resolving ImageStreamTag origin-operator-registry:4.15 in namespace openshift-marketplace: unable to find latest tagged image
/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fa0a998 and 0 for PR HEAD 61cffda in total

@openshift-ci-robot
Copy link

/hold

Revision 61cffda was retested 3 times: holding

Copy link

openshift-ci bot commented Mar 21, 2024

@maschmid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/411-test-encryption-auth-e2e-aws-411 61cffda link true /test 411-test-encryption-auth-e2e-aws-411
ci/prow/411-test-e2e-aws-411 61cffda link true /test 411-test-e2e-aws-411
ci/prow/411-test-reconciler-aws-411 61cffda link true /test 411-test-reconciler-aws-411
ci/prow/412-test-encryption-auth-e2e-aws-412 61cffda link true /test 412-test-encryption-auth-e2e-aws-412
ci/prow/416-images 61cffda link true /test 416-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants