[release-4.9] Bug 2075551: kubebuilder validation format hostname is not RFC compliant #1181

openshift-cherrypick-robot · 2022-04-14T14:00:15Z

This is an automated cherry-pick of #1162

/assign candita

openshift-ci · 2022-04-14T14:00:30Z

@openshift-cherrypick-robot: Bugzilla bug 2072739 has been cloned as Bugzilla bug 2075551. Retitling PR to link against new bug.
/retitle [release-4.9] [release-4.10] Bug 2075551: kubebuilder validation format hostname is not RFC compliant

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-04-14T14:00:39Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2075551, which is invalid:

expected dependent Bugzilla bug 2072739 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-04-14T14:10:36Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

candita · 2022-04-14T14:20:25Z

/retitle [release-4.9] Bug 2075551: kubebuilder validation format hostname is not RFC compliant

candita · 2022-04-14T17:48:43Z

/assign @soltysh - please add backport-risk-assessed, as you did for #1162

candita · 2022-04-14T17:49:42Z

/assign @deads2k - please approve, as you did for #1162

candita · 2022-04-14T17:52:22Z

@gangwgr - please label this with cherry-pick-approved, as you did for #1162

soltysh

/label backport-risk-assessed
/approve

rfredette · 2022-04-18T16:59:03Z

/lgtm

openshift-ci · 2022-04-18T16:59:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, rfredette, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

candita · 2022-04-18T17:23:20Z

/bugzilla refresh

openshift-ci · 2022-04-18T17:23:40Z

@candita: This pull request references Bugzilla bug 2075551, which is invalid:

expected dependent Bugzilla bug 2072739 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

candita · 2022-04-19T00:20:27Z

ping @gangwgr - can you please label this with cherry-pick-approved, as you did for #1162 ?

openshift-bot · 2022-04-19T01:00:47Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-04-23T01:01:10Z

@openshift-bot: This pull request references Bugzilla bug 2075551, which is invalid:

expected dependent Bugzilla bug 2072739 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-04-24T01:00:55Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-04-24T01:01:06Z

@openshift-bot: This pull request references Bugzilla bug 2075551, which is invalid:

expected dependent Bugzilla bug 2072739 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-04-25T01:00:58Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-04-25T01:01:09Z

@openshift-bot: This pull request references Bugzilla bug 2075551, which is invalid:

expected dependent Bugzilla bug 2072739 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-04-26T01:00:23Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-04-26T01:00:35Z

@openshift-bot: This pull request references Bugzilla bug 2075551, which is invalid:

expected dependent Bugzilla bug 2072739 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-04-27T01:01:05Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-04-27T01:01:22Z

@openshift-bot: This pull request references Bugzilla bug 2075551, which is invalid:

expected dependent Bugzilla bug 2072739 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-04-28T01:00:46Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-04-28T01:01:07Z

@openshift-bot: This pull request references Bugzilla bug 2075551, which is invalid:

expected dependent Bugzilla bug 2072739 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-04-29T01:01:15Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-04-29T01:01:35Z

@openshift-bot: This pull request references Bugzilla bug 2075551, which is invalid:

expected dependent Bugzilla bug 2072739 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-04-30T01:00:27Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-04-30T01:00:47Z

@openshift-bot: This pull request references Bugzilla bug 2075551, which is invalid:

expected dependent Bugzilla bug 2072739 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-05-01T01:00:27Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-05-01T01:00:42Z

@openshift-bot: This pull request references Bugzilla bug 2075551, which is invalid:

expected dependent Bugzilla bug 2072739 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-05-02T01:00:42Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-05-02T01:01:03Z

@openshift-bot: This pull request references Bugzilla bug 2075551, which is invalid:

expected dependent Bugzilla bug 2072739 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

candita · 2022-05-02T16:24:10Z

/bugzilla refresh

openshift-ci · 2022-05-02T16:24:27Z

@candita: This pull request references Bugzilla bug 2075551, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.z) matches configured target release for branch (4.9.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2072739 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2072739 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
bug has dependents

Requesting review from QA contact:
/cc @quarterpin

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-05-02T16:26:07Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/api#1181

Bugzilla bug 2075551 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

candita · 2022-05-03T18:26:09Z

/cherry-pick release-4.8

openshift-cherrypick-robot · 2022-05-03T18:26:45Z

@candita: #1181 failed to apply on top of branch "release-4.8":

Applying: Bug 2039256: kubebuilder validation format hostname is not RFC compliant
Using index info to reconstruct a base tree...
M	config/v1/0000_10_config-operator_01_ingress.crd.yaml
M	config/v1/types_ingress.go
Falling back to patching base and 3-way merge...
Auto-merging config/v1/types_ingress.go
Auto-merging config/v1/0000_10_config-operator_01_ingress.crd.yaml
CONFLICT (content): Merge conflict in config/v1/0000_10_config-operator_01_ingress.crd.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bug 2039256: kubebuilder validation format hostname is not RFC compliant
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bug 2039256: kubebuilder validation format hostname is not RFC compliant

019a246

openshift-cherrypick-robot mentioned this pull request Apr 14, 2022

[release-4.10] Bug 2072739: kubebuilder validation format hostname is not RFC compliant #1162

Merged

openshift-ci bot assigned candita Apr 14, 2022

openshift-ci bot changed the title ~~[release-4.9] [release-4.10] Bug 2072739: kubebuilder validation format hostname is not RFC compliant~~ [release-4.9] [release-4.10] Bug 2075551: kubebuilder validation format hostname is not RFC compliant Apr 14, 2022

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 14, 2022

openshift-ci bot requested review from derekwaynecarr and jwforres April 14, 2022 14:00

openshift-ci bot changed the title ~~[release-4.9] [release-4.10] Bug 2075551: kubebuilder validation format hostname is not RFC compliant~~ [release-4.9] Bug 2075551: kubebuilder validation format hostname is not RFC compliant Apr 14, 2022

soltysh approved these changes Apr 14, 2022

View reviewed changes

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 14, 2022

openshift-ci bot assigned gangwgr, wangke19 and xingxingxia Apr 14, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2022

openshift-ci bot assigned rfredette Apr 18, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2022

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 2, 2022

openshift-ci bot requested a review from quarterpin May 2, 2022 16:24

openshift-merge-robot merged commit a191b4b into openshift:release-4.9 May 2, 2022

candita mentioned this pull request May 3, 2022

Bug 2039256: kubebuilder validation format hostname is not RFC compliant #1120

Merged

openshift-ci bot mentioned this pull request May 9, 2022

Bug 2075551: [release-4.9] backport api to commit 019a246c52 openshift/cluster-config-operator#252

Merged

[release-4.9] Bug 2075551: kubebuilder validation format hostname is not RFC compliant #1181

[release-4.9] Bug 2075551: kubebuilder validation format hostname is not RFC compliant #1181

Conversation

openshift-cherrypick-robot commented Apr 14, 2022

openshift-ci bot commented Apr 14, 2022

openshift-ci bot commented Apr 14, 2022

openshift-ci bot commented Apr 14, 2022

candita commented Apr 14, 2022

candita commented Apr 14, 2022

candita commented Apr 14, 2022

candita commented Apr 14, 2022

soltysh left a comment

Choose a reason for hiding this comment

rfredette commented Apr 18, 2022

openshift-ci bot commented Apr 18, 2022

candita commented Apr 18, 2022

openshift-ci bot commented Apr 18, 2022

candita commented Apr 19, 2022

openshift-bot commented Apr 19, 2022

openshift-ci bot commented Apr 23, 2022

openshift-bot commented Apr 24, 2022

openshift-ci bot commented Apr 24, 2022

openshift-bot commented Apr 25, 2022

openshift-ci bot commented Apr 25, 2022

openshift-bot commented Apr 26, 2022

openshift-ci bot commented Apr 26, 2022

openshift-bot commented Apr 27, 2022

openshift-ci bot commented Apr 27, 2022

openshift-bot commented Apr 28, 2022

openshift-ci bot commented Apr 28, 2022

openshift-bot commented Apr 29, 2022

openshift-ci bot commented Apr 29, 2022

openshift-bot commented Apr 30, 2022

openshift-ci bot commented Apr 30, 2022

openshift-bot commented May 1, 2022

openshift-ci bot commented May 1, 2022

openshift-bot commented May 2, 2022

openshift-ci bot commented May 2, 2022

candita commented May 2, 2022

openshift-ci bot commented May 2, 2022

openshift-ci bot commented May 2, 2022

candita commented May 3, 2022

openshift-cherrypick-robot commented May 3, 2022