Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPCLOUD-1777: "External" platform type #1301

Merged
merged 1 commit into from Dec 16, 2022
Merged

OCPCLOUD-1777: "External" platform type #1301

merged 1 commit into from Dec 16, 2022

Conversation

lobziik
Copy link
Contributor

@lobziik lobziik commented Sep 19, 2022 •
edited

Adds "External" platform type.

Enhancement: openshift/enhancements#1234
Feature link: https://issues.redhat.com/browse/OCPBU-5

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2022

Hello @lobziik! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard lgtm and approved labels this repository requires either:

bugzilla/valid-bug - applied if your PR references a valid bugzilla bug

OR

qe-approved, docs-approved, and px-approved - these labels can be applied by anyone in the openshift org via the /label <labelname> command.

Who should apply these qe/docs/px labels?

  • For a no-Feature-Freeze team who is merging a feature before code freeze, they need to get those labels applied to their api repo PR by the appropriate teams (i.e. qe, docs, px)
  • For a Feature Freeze (traditional) team who is merging a feature before FF, they can self-apply the labels (via /label commands), they are basically irrelevant for those teams
  • For a Feature Freeze team who is merging a feature after FF, the PR should be rejected barring an exception

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2022
@lobziik lobziik changed the title WIP: "External" platform type OCPCLOUD-1777: "External" platform type Dec 7, 2022
@lobziik
Copy link
Contributor Author

lobziik commented Dec 7, 2022

/cc @JoelSpeed

@openshift-ci openshift-ci bot requested a review from JoelSpeed December 7, 2022 14:58
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 7, 2022
@lobziik lobziik force-pushed the platform_external branch 2 times, most recently from 031b573 to 4264c92 Compare December 7, 2022 15:00
@lobziik
Copy link
Contributor Author

lobziik commented Dec 7, 2022

Updated old WIP pr, now it reflects the EP document. Also, added validation for the ProviderName field as was discussed during the EP review.

/cc @elmiko jfyi

@openshift-ci openshift-ci bot requested a review from elmiko December 7, 2022 15:03
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 7, 2022

@lobziik: GitHub didn't allow me to request PR reviews from the following users: jfyi.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Updated old WIP pr, now it reflects the EP document. Also, added validation for the ProviderName field as was discussed during the EP review.

/cc @elmiko jfyi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoelSpeed
JoelSpeed reviewed Dec 7, 2022
View reviewed changes
config/v1/types_infrastructure.go Outdated Show resolved Hide resolved
config/v1/types_infrastructure.go Outdated Show resolved Hide resolved
config/v1/types_infrastructure.go Outdated Show resolved Hide resolved
config/v1/types_infrastructure.go Outdated Show resolved Hide resolved
config/v1/types_infrastructure.go Outdated Show resolved Hide resolved
config/v1/types_infrastructure.go Outdated Show resolved Hide resolved
config/v1/types_infrastructure.go Outdated Show resolved Hide resolved
config/v1/types_infrastructure.go Outdated Show resolved Hide resolved
@lobziik lobziik force-pushed the platform_external branch 3 times, most recently from 1249821 to d521900 Compare December 8, 2022 12:11
elmiko
elmiko reviewed Dec 8, 2022
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code looks good to me, but i have some stylistic thoughts about the field name we are using for ProviderName. i should have brought this up on the enhancement, but it occurred to me while reading the code here again.

config/v1/types_infrastructure.go Outdated Show resolved Hide resolved
config/v1/types_infrastructure.go Outdated Show resolved Hide resolved
config/v1/types_infrastructure.go Show resolved Hide resolved
@lobziik
Copy link
Contributor Author

lobziik commented Dec 9, 2022

Updated naming.

I accommodated platform language, instead of provider. @elmiko PTAL, hope it looks better now.

JoelSpeed
JoelSpeed reviewed Dec 9, 2022
View reviewed changes
config/v1/types_infrastructure.go Outdated Show resolved Hide resolved
config/v1/types_infrastructure.go Outdated Show resolved Hide resolved
config/v1/types_infrastructure.go Outdated Show resolved Hide resolved
elmiko
elmiko reviewed Dec 9, 2022
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking really nice to me, thanks @lobziik
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2022
@lobziik
Copy link
Contributor Author

lobziik commented Dec 12, 2022 •
edited

/cc @dhellmann, can you please take a look?

We think it's ok to merge this in, but it would be cool to have a blessing :)

@dhellmann
Copy link

/lgtm

Nice work!

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2022
@elmiko
Copy link
Contributor

elmiko commented Dec 13, 2022

this is related to feature OCPBU-5

@sferich888
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Dec 16, 2022
@elmiko
Copy link
Contributor

elmiko commented Dec 16, 2022

/label docs-approved
/label qe-approved
/approve

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Dec 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, elmiko, JoelSpeed, lobziik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2022

@lobziik: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4beb701 into openshift:master Dec 16, 2022
@elmiko elmiko mentioned this pull request Dec 20, 2022
Merged
elmiko added a commit to elmiko/openshift-enhancements that referenced this pull request Dec 20, 2022
@elmiko
update external provider enhancement
5536893 
this change updates a name from the code sample to be consistent with
the created code. When reviewing the code for the API implementation of
the external platform type, we had a realization about the variable name
we are using to distinguish the provider supplied name for the
infrastructure. For more information, see the discussion on original
pull request[0].

[0] openshift/api#1301
frobware added a commit to frobware/cluster-ingress-operator that referenced this pull request Jan 17, 2023
@frobware
vendor: openshift/api: bump for "External" platform type
85d15c1 
The "External" plaftform type was introduced with
openshift/api#1301.

Steps:

- go get github.com/openshift/api@4beb701aa75b8b2c262322afee802c49d647f5a1
- go mod vendor
- go mod tidy
- make update
- make

Required as part of https://issues.redhat.com/browse/NE-1123.
frobware added a commit to frobware/cluster-ingress-operator that referenced this pull request Jan 17, 2023
@frobware
vendor: openshift/api: bump for "External" platform type
ed68d8b 
The "External" plaftform type was introduced with
openshift/api#1301.

Steps:

- go get github.com/openshift/api@4beb701aa75b8b2c262322afee802c49d647f5a1
- go mod vendor
- go mod tidy
- make update
- make
- make test

Required as part of https://issues.redhat.com/browse/NE-1123.
@frobware frobware mentioned this pull request Jan 17, 2023
Merged
@lobziik lobziik mentioned this pull request Feb 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko elmiko left review comments

@JoelSpeed JoelSpeed JoelSpeed left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@dhellmann dhellmann

@elmiko elmiko

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lobziik @dhellmann @JoelSpeed @elmiko @sferich888 @openshift-merge-robot