Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCPCLOUD-2034] Add Azure/GCP specific external cloud provider feature gates #1444

Merged

Conversation

JoelSpeed
Copy link
Contributor

We need to have the ability to promote these two providers individually. I will teach the library-go code to observer both feature gates for these platforms and then, once we have the new feature gate, status based decisions in place, will be able to promote each of these individually in a single PR.

CC @deads2k have I missed anything for adding a new feature gate?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 24, 2023

Hello @JoelSpeed! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 24, 2023
@openshift-ci openshift-ci bot requested review from knobunc and soltysh April 24, 2023 11:18
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2023
@JoelSpeed JoelSpeed changed the title Add Azure/GCP specific external cloud provider feature gates [OCPCLOUD-2034] Add Azure/GCP specific external cloud provider feature gates Apr 24, 2023
We need to have the ability to promote these two providers
individually. I will teach the library-go code to observer both
feature gates for these platforms and then, once we have the
new feature gate, status based decisions in place, will be able
to promote each of these individually in a single PR.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2023

@JoelSpeed: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor

deads2k commented Apr 25, 2023

/lgtm

@deads2k
Copy link
Contributor

deads2k commented Apr 25, 2023

at some future point, we should have a more structured registry.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9a7a7c1 into openshift:master Apr 25, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants