Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config/v1/types_cluster_version: Drop never-implemented 'Evaluating' conditionalUpdates condition type #1753

Merged
merged 1 commit into from Feb 13, 2024
Merged

config/v1/types_cluster_version: Drop never-implemented 'Evaluating' conditionalUpdates condition type #1753

merged 1 commit into from Feb 13, 2024

Conversation

wking
Copy link
Member

@wking wking commented Feb 6, 2024

Catching up with openshift/enhancements@c446cd7846 (openshift/enhancements#1420), which points out that this type was never implemented, because Recommended=Unknown is sufficient to say "we're trying (and failing) to figure out if some of the target's risks apply to the cluster".

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

Hello @wking! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 6, 2024
@wking
config/v1/types_cluster_version: Drop never-implemented 'Evaluating' …
50677c8 
…conditionalUpdates condition type

Catching up with openshift/enhancements@c446cd7846
(enhancements/update/targeted-update-edge-blocking: Drop Evaluating,
2023-06-07, openshift/enhancements#1420), which points out that this
type was never implemented, because Recommended=Unknown is sufficient
to say "we're trying (and failing) to figure out if some of the
target's risks apply to the cluster".
@wking wking force-pushed the drop-conditionalUpdates-Evaluating branch from 93c093e to 50677c8 Compare February 6, 2024 04:36
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 6, 2024
LalatenduMohanty
LalatenduMohanty approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2024
@JoelSpeed
Copy link
Contributor

Docs only change
/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, LalatenduMohanty, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 04ea389 and 2 for PR HEAD 50677c8 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 06532f4 and 1 for PR HEAD 50677c8 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 54b3334 into openshift:master Feb 13, 2024
9 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.16.0-202402130639.p0.g54b3334.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

@wking wking deleted the drop-conditionalUpdates-Evaluating branch February 13, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@LalatenduMohanty LalatenduMohanty

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wking @JoelSpeed @openshift-ci-robot @openshift-bot @LalatenduMohanty