Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the clusteroperator version #176

Merged
merged 1 commit into from
Jan 21, 2019

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jan 21, 2019

Updates the clusteroperator resource to match https://docs.google.com/document/d/1YV_rJ6qR46_DV1s6RwobTYHX0CCE4CIBnt_VRPtN8Nw/edit#heading=h.j35cxjc8vibg and handle cases with multiple operands. The updated doc and structure makes it clear that we have multiple versions in play.

Until the clusteroperator has been updated to provide a mapping from image to version, you can place an image pull spec in version to prove your plumbing.

@smarterclayton @derekwaynecarr per the doc

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 21, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2019
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b4c87b2 into openshift:master Jan 21, 2019
abhinavdahiya added a commit to abhinavdahiya/cluster-version-operator that referenced this pull request Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants