make the serialized featuregate location an input param #1790
Conversation
|
Hello @deads2k! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/M
openshift-ci
bot
added
the
approved
| featureGateFilename := "" | ||
| switch { | ||
| case featureSetName == "TechPreviewNoUpgrade": | ||
| featureGateFilename = "payload-manifests/featuregates/featureGate-TechPreviewNoUpgrade.yaml" | ||
| featureGateFilename = path.Join(payloadFeatureGatePath, "featureGate-TechPreviewNoUpgrade.yaml") |
There was a problem hiding this comment.
Will your other PR adjusting the way we construct feature gates change this at all?
There was a problem hiding this comment.
Will your other PR adjusting the way we construct feature gates change this at all?
Coming later, but this fixes the immediate debt and the next bit affects the names.
| @@ -30,6 +33,8 @@ var crdManifestMerge = &cobra.Command{ | |||
|
|
|||
| func init() { | |||
| rootCmd.AddCommand(crdManifestMerge) | |||
|
|
|||
| rootCmd.PersistentFlags().StringVar(&manifestMergePayloadManifestPath, "manifest-merge:payload-manifest-path", manifestmerge.DefaultPayloadFeatureGatePath, "path to locate the featuregate YAML.") | |||
There was a problem hiding this comment.
Since this is a dir expecting multiple files, may want to make it clearer that this is a dir
deads2k
force-pushed
the
by-gate-04-path
branch
from
e96d897
to
b0fe1d7
Compare
|
@deads2k: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fulfills IOU from the featuregate PR
/assign @JoelSpeed