Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Merge pull request #1851 from slashpai/metrics-server"" #1865

Merged
merged 1 commit into from May 15, 2024

Conversation

slashpai
Copy link
Member

@slashpai slashpai commented Apr 23, 2024

Fix is added in openshift/cluster-monitoring-operator#2334

SNO fix in openshift/cluster-monitoring-operator#2337

This reverts commit a7a9d56.

Adding placeholder to add back the feature gate to default and testing payload jobs before merging

/hold

cc: @machine424 @jan--f

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 23, 2024
Copy link
Contributor

openshift-ci bot commented Apr 23, 2024

Hello @slashpai! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 23, 2024
@slashpai
Copy link
Member Author

Once openshift/cluster-monitoring-operator#2329 is merged will verify the payload jobs as mentioned in #1863

Copy link
Contributor

openshift-ci bot commented Apr 23, 2024

@jan--f: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2329
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d8dbc4d0-0169-11ef-80b3-937f07d81a34-0

Copy link
Contributor

openshift-ci bot commented Apr 23, 2024

@slashpai: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2329
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/346f42d0-016b-11ef-9c35-974f633a4f3f-0

Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

@slashpai: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2329
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e5caf660-0214-11ef-8541-c562082f3eaa-0

Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9dbc6850-0259-11ef-9e43-91a4f4b17de5-0

Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e77c90a0-0259-11ef-92b5-46f4e3c5ea9b-0

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@slashpai: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2329
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f972a990-02a7-11ef-85c8-8a3d6e2fa727-0

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@slashpai: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2329
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/aaa566b0-02b4-11ef-86e4-14f7e6cef418-0

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/08763970-02d5-11ef-82c2-1f947f29a0f2-0

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1e127370-02d5-11ef-97af-1d2088b40c8e-0

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7f533b40-02d7-11ef-8c02-887ff64c5f91-0

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/952ccc60-02d7-11ef-812b-00c219e3f7ee-0

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@machine424: This PR was included in a payload test run from openshift/origin#28737
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ce85df90-02de-11ef-8c62-2e3db784f5f9-0

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@machine424: This PR was included in a payload test run from openshift/origin#28737
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@machine424: This PR was included in a payload test run from openshift/origin#28737
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/77395d40-02e1-11ef-97dd-2274b69c7a75-0

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0bcb3d90-02e5-11ef-88cf-4f39eb501bae-0

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.16-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e54431c0-02e6-11ef-8f89-cc5fc554685e-0

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5d951ca0-02ee-11ef-9a17-e1aef94cff96-0

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2329
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b85820b0-02ee-11ef-8b3a-9bacb4e24e64-0

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8a9d9a10-030c-11ef-99a4-cc9de0e1dc97-0

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5d2c8c70-0312-11ef-98a4-0fcb178406dc-0

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2268
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4bbc5370-0313-11ef-9250-ffcbefb52abe-0

Copy link
Contributor

openshift-ci bot commented May 13, 2024

@slashpai: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2337
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5a5eb190-1117-11ef-93e5-df91624bf14d-0

@slashpai
Copy link
Member Author

/retest

1 similar comment
@slashpai
Copy link
Member Author

/retest

@slashpai
Copy link
Member Author

/payload-job periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance

Copy link
Contributor

openshift-ci bot commented May 14, 2024

@slashpai: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d1304c00-11b9-11ef-8234-e716ff5658d4-0

@slashpai
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node

Copy link
Contributor

openshift-ci bot commented May 14, 2024

@slashpai: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ea8d85a0-11b9-11ef-98f4-6bab88c48b85-0

@slashpai slashpai changed the title WIP Revert "Revert "Merge pull request #1851 from slashpai/metrics-server"" Revert "Revert "Merge pull request #1851 from slashpai/metrics-server"" May 14, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2024
@slashpai
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node

Copy link
Contributor

openshift-ci bot commented May 14, 2024

@slashpai: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bb7bcb10-11e5-11ef-9bc7-9e0691688c9a-0

@simonpasquier
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
@JoelSpeed
Copy link
Contributor

QE already signed off on this, TRT reverted and requested HyperShift conformance on the un-revert, can see that's green here so happy to continue

/lgtm
/override ci/prow/verify

Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, simonpasquier, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
Copy link
Contributor

openshift-ci bot commented May 14, 2024

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify

In response to this:

QE already signed off on this, TRT reverted and requested HyperShift conformance on the un-revert, can see that's green here so happy to continue

/lgtm
/override ci/prow/verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@slashpai
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2024
@juzhao
Copy link

juzhao commented May 15, 2024

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 15, 2024
@slashpai
Copy link
Member Author

/payload 4.16 nightly blocking

Copy link
Contributor

openshift-ci bot commented May 15, 2024

@slashpai: trigger 8 job(s) of type blocking for the nightly release of OCP 4.16

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-sdn-upgrade
  • periodic-ci-openshift-release-master-ci-4.16-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.16-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/65cf6820-1280-11ef-9184-7fd52980e1ee-0

@slashpai
Copy link
Member Author

We already tested hypershift and sno payload test which were failing in previous attempt before fix

hypershift: #1865 (comment)
sno: #1865 (comment)

/label acknowledge-critical-fixes-only

cc: @jan--f @simonpasquier @machine424

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label May 15, 2024
Copy link
Contributor

openshift-ci bot commented May 15, 2024

@slashpai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 14ae5de into openshift:master May 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants