OCPBUGS-32510: tweak Prometheus RBAC setup as a temp fix. #2334
Conversation
openshift-ci-robot
added
jira/severity-critical
|
@machine424: This pull request references Jira Issue OCPBUGS-32510, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
| @@ -40,6 +40,32 @@ func (t *MetricsServerTask) Run(ctx context.Context) error { | |||
| } | |||
|
|
|||
| func (t *MetricsServerTask) create(ctx context.Context) error { | |||
| { | |||
| // TODO: This is a temporary workaround until the requirements for https://github.com/openshift/cluster-monitoring-operator/pull/2329 | |||
There was a problem hiding this comment.
put it here to make it easier to revert + to not bend MetricsClientCATask and make it look as a good fix.
openshift-ci
bot
added
the
approved
|
/payload-job-with-prs periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance openshift/api#1865 |
|
@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f690e7b0-061b-11ef-9fd2-47a92bba20d9-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node openshift/api#1865 |
|
@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/076427f0-061c-11ef-9ef0-5fb887b41964-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.16-e2e-aws-ovn openshift/api#1865 |
|
@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4fbb7170-061c-11ef-8f50-6f9c4ffaf8f8-0 |
See the added comments and https://docs.google.com/document/d/1VpGBbV30-bb-eq-JYi2q5B8Hyll37tp30OrHcnCifpo/edit?usp=sharing for more details
See the added comments and https://docs.google.com/document/d/1VpGBbV30-bb-eq-JYi2q5B8Hyll37tp30OrHcnCifpo/edit?usp=sharing for more details
|
@machine424: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| // Because the metrics-server Pods rely on the system:serviceaccount:openshift-monitoring:prometheus-k8s SA to reach kubelet, | ||
| // the task needs to ensure that the necessary RBAC permissions for that SA are set up before starting the Pods to avoid scrape failures. | ||
| // For detailed information, refer to: https://issues.redhat.com/browse/OCPBUGS-32510. | ||
| cr, err := t.factory.PrometheusK8sClusterRole() |
There was a problem hiding this comment.
should we not have prometheus service account also setup ?
There was a problem hiding this comment.
the prometheus SA is not used directly.
metrics-server just uses a client cert that is issued for the prometheus SA and kubelet uses the RBAC authz to make sure that client=metrics-server=prometheus SA has the required permissions (get /metrics of nodes)
There was a problem hiding this comment.
(kubelet will not check that the SA exists and RBAC can be defined and applied even for non existing SA, IIRC)
|
/skip |
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node openshift/api#1865,openshift/kubernetes-metrics-server#26,openshift/kubernetes#1960,openshift/machine-config-operator#4338 |
|
@machine424: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node openshift/api#1865 openshift/kubernetes-metrics-server#26 openshift/kubernetes#1960 openshift/machine-config-operator#4338 |
|
@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/03f35510-0896-11ef-802d-50a22c76e308-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node openshift/api#1865 openshift/kubernetes-metrics-server#26 openshift/kubernetes#1960 openshift/machine-config-operator#4338 |
|
@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8e57e7a0-091a-11ef-938e-27baa3eaae5d-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node openshift/api#1865 openshift/kubernetes-metrics-server#26 openshift/kubernetes#1960 openshift/machine-config-operator#4338 |
|
@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8c828630-092c-11ef-9a2d-618f2d601a8f-0 |
openshift-ci
bot
added
the
do-not-merge/hold
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node openshift/api#1878 openshift/kubernetes-metrics-server#26 openshift/kubernetes#1960 |
|
@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7edfae70-0965-11ef-9e7d-f89ee8db2303-0 |
…cs-server"" Fix is added in openshift/cluster-monitoring-operator#2334 This reverts commit a7a9d56.
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node openshift/api#1865 |
|
@slashpai: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d0cc0670-096a-11ef-9dbc-acfab9cb5559-0 |
|
/payload-job-with-prs periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn-conformance openshift/api#1865 |
|
@slashpai: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f6994d40-096a-11ef-92d9-e176bdd904a1-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node openshift/api#1878 openshift/kubernetes-metrics-server#26 openshift/kubernetes#1960 |
|
@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/56fe3270-0b7a-11ef-8f34-6b42ed678a2f-0 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: machine424, simonpasquier, slashpai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@machine424: Jira Issue OCPBUGS-32510: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-32510 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-monitoring-operator-container-v4.17.0-202405061412.p0.g93a4599.assembly.stream.el9 for distgit cluster-monitoring-operator. |
…cs-server"" Fix is added in openshift/cluster-monitoring-operator#2334 This reverts commit a7a9d56.
OCPBUGS-32510: adapt the metrics-server readiness probe config.
See the added comments and https://docs.google.com/document/d/1VpGBbV30-bb-eq-JYi2q5B8Hyll37tp30OrHcnCifpo/edit?usp=sharing for more details
/cc @slashpai
/cc @simonpasquier