-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ETCD-520: add BackendQuotaGiB example #1874
ETCD-520: add BackendQuotaGiB example #1874
Conversation
@Elbehery: This pull request references ETCD-520 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Hello @Elbehery! Some important instructions when contributing to openshift/api: |
@Elbehery: This pull request references ETCD-520 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
d3a72fd
to
b79d8a8
Compare
b79d8a8
to
ba8ffd0
Compare
Example looks good, you'll need to update the existing test cases now though as the new default value is making the |
ba8ffd0
to
c461fdd
Compare
updated 👍🏽 |
You'll need to update all the cases not just the first one, quite a few will have the new default effect them |
c461fdd
to
14cdc8a
Compare
i dont think all the other cases, because the failure differs on specific case for specific feature gate iiuc lets see how it goes now, then i update the failures :) thanks a lot for your quick reviews 🙏🏽 🙏🏽 🙏🏽 |
11dc5f3
to
6ad588c
Compare
6ad588c
to
a782226
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Elbehery, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Elbehery: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-config-api-container-v4.17.0-202405072356.p0.g62b890e.assembly.stream.el9 for distgit ose-cluster-config-api. |
This PR adds an example for a new field
BackendQuotaGiB
withinEtcdSpec
type.Example for #1736
see https://issues.redhat.com/browse/ETCD-513
cc @openshift/openshift-team-etcd @JoelSpeed @deads2k