Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETCD-520: add BackendQuotaGiB example #1874

Merged

Conversation

Elbehery
Copy link
Contributor

@Elbehery Elbehery commented Apr 29, 2024

This PR adds an example for a new field BackendQuotaGiB within EtcdSpec type.

Example for #1736

see https://issues.redhat.com/browse/ETCD-513

cc @openshift/openshift-team-etcd @JoelSpeed @deads2k

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 29, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 29, 2024

@Elbehery: This pull request references ETCD-520 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR adds an example for a new field BackendQuotaGiB within EtcdSpec type.

see https://issues.redhat.com/browse/ETCD-513

cc @openshift/openshift-team-etcd @JoelSpeed @deads2k

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

Hello @Elbehery! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 29, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 29, 2024

@Elbehery: This pull request references ETCD-520 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR adds an example for a new field BackendQuotaGiB within EtcdSpec type.

Example for #1736

see https://issues.redhat.com/browse/ETCD-513

cc @openshift/openshift-team-etcd @JoelSpeed @deads2k

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Elbehery Elbehery force-pushed the add_BackendQuotaGiB_example branch from d3a72fd to b79d8a8 Compare April 29, 2024 15:21
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 29, 2024
@Elbehery Elbehery force-pushed the add_BackendQuotaGiB_example branch from b79d8a8 to ba8ffd0 Compare May 1, 2024 18:58
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 1, 2024
@JoelSpeed
Copy link
Contributor

Example looks good, you'll need to update the existing test cases now though as the new default value is making the expected values wrong

@Elbehery Elbehery force-pushed the add_BackendQuotaGiB_example branch from ba8ffd0 to c461fdd Compare May 3, 2024 09:01
@Elbehery
Copy link
Contributor Author

Elbehery commented May 3, 2024

Example looks good, you'll need to update the existing test cases now though as the new default value is making the expected values wrong

updated 👍🏽

@JoelSpeed
Copy link
Contributor

You'll need to update all the cases not just the first one, quite a few will have the new default effect them

@Elbehery Elbehery force-pushed the add_BackendQuotaGiB_example branch from c461fdd to 14cdc8a Compare May 3, 2024 10:35
@Elbehery
Copy link
Contributor Author

Elbehery commented May 3, 2024

You'll need to update all the cases not just the first one, quite a few will have the new default effect them

i dont think all the other cases, because the failure differs on specific case for specific feature gate iiuc

lets see how it goes now, then i update the failures :)

thanks a lot for your quick reviews 🙏🏽 🙏🏽 🙏🏽

@Elbehery Elbehery force-pushed the add_BackendQuotaGiB_example branch 2 times, most recently from 11dc5f3 to 6ad588c Compare May 3, 2024 16:30
@Elbehery Elbehery force-pushed the add_BackendQuotaGiB_example branch from 6ad588c to a782226 Compare May 3, 2024 18:37
@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
Copy link
Contributor

openshift-ci bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
Copy link
Contributor

openshift-ci bot commented May 7, 2024

@Elbehery: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 62b890e into openshift:master May 7, 2024
9 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.17.0-202405072356.p0.g62b890e.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants