Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: Deprecate build.spec.additionalTrustedCA #324

Closed
wants to merge 1 commit into from
Closed

config: Deprecate build.spec.additionalTrustedCA #324

wants to merge 1 commit into from

Conversation

adambkaplan
Copy link
Contributor

AdditionalTrustedCAs referenced in build.config.openshift.io/cluster were never used in OpenShift 4.1.
Mark existing field as deprecated and schedule for future removal.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 28, 2019
@adambkaplan
Copy link
Contributor Author

/assign @bparees

fyi @bmcelvee @openshift/openshift-team-developer-experience

derekwaynecarr
derekwaynecarr reviewed May 28, 2019
View reviewed changes
config/v1/types_build.go Outdated
//
// Deprecated: this reference is not used in OpenShift builds.
// Configure additional CAs by setting the `spec.additionalTrustedCA` ConfigMap
// refrence on the `image.config.openshift.io/cluster` object instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: reference

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derekwaynecarr fixed

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adambkaplan
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: bparees

If they are not already assigned, you can assign the PR to them by writing /assign @bparees in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adambkaplan
config: Deprecate build.spec.additionalTrustedCA
c632ced 
AdditionalTrustedCAs referenced in build.config.openshift.io/cluster
were never used in OpenShift 4.1.
Mark existing field as deprecated and schedule for future removal.
@adambkaplan
Copy link
Contributor Author

/close

Deprecated in #406

@openshift-ci-robot
Copy link

@adambkaplan: Closed this PR.

In response to this:

/close

Deprecated in #406

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr derekwaynecarr left review comments

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@bparees bparees

Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adambkaplan @openshift-ci-robot @derekwaynecarr @bparees