-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1809354: operatoringress/dnsrecord: Add observedGeneration #644
Bug 1809354: operatoringress/dnsrecord: Add observedGeneration #644
Conversation
@Miciah: This pull request references Bugzilla bug 1809354, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test verify |
b7cda48
to
6016ee0
Compare
/lgtm |
|
||
// observedGeneration is the most recent generation observed. | ||
// +optional | ||
ObservedGeneration int64 `json:"observedGeneration,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like different zones could have different observed generations. What happens if some zones are generation 8 and others are at generation 12?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be worthy to move this to DNSZoneCondition to match the direction upstream is heading with https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/1623-standardize-conditions/README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like different zones could have different observed generations. What happens if some zones are generation 8 and others are at generation 12?
The current logic is that the controller will see that the generation has changed, update each zone, and update the status for each zone. If updating a zone fails, then the status for that zone will reflect that the update failed, and the next time the controller's control loop runs, it sees that it has a zone with status condition Failed=True
and retries the update.
Maybe it would be worthy to move this to DNSZoneCondition to match the direction upstream is heading with https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/1623-standardize-conditions/README.md
That's an interesting proposal. As described above, the controller can do the right thing with a single status.observedGenerate
field, but would you like me to change it to status.zones[*].observedGeneration
for consistency with the KEP you cited?
This commit is needed to fix bug 1809354. https://bugzilla.redhat.com/show_bug.cgi?id=1809354 * operatoringress/v1/types.go (DNSRecordStatus): Add ObservedGeneration field. * operatoringress/v1/0000_50_dns-record.yaml: * operatoringress/v1/zz_generated.swagger_doc_generated.go: Regenerate.
6016ee0
to
783740a
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans, deads2k, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Miciah: Some pull requests linked via external trackers have merged: openshift/api#644. The following pull requests linked via external trackers have not merged:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
operatoringress/v1/types.go
(DNSRecordStatus
): AddObservedGeneration
field.operatoringress/v1/0000_50_dns-record.yaml
: Regenerate.