Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: rename docker image for postgres 12 as latest tag disappeared #6116

Merged

Conversation

rccrdpccl
Copy link
Contributor

@rccrdpccl rccrdpccl commented Mar 27, 2024

Trying to pull quay.io/centos7/postgresql-12-centos7:latest...
WARN[0001] Failed, retrying in 1s ... (1/3). Error: initializing source docker://quay.io/centos7/postgresql-12-centos7:latest: reading manifest latest in quay.io/centos7/postgresql-12-centos7: unknown: Tag latest was deleted or has expired. To pull, revive via time machine
WARN[0003] Failed, retrying in 1s ... (2/3). Error: initializing source docker://quay.io/centos7/postgresql-12-centos7:latest: reading manifest latest in quay.io/centos7/postgresql-12-centos7: unknown: Tag latest was deleted or has expired. To pull, revive via time machine
WARN[0006] Failed, retrying in 1s ... (3/3). Error: initializing source docker://quay.io/centos7/postgresql-12-centos7:latest: reading manifest latest in quay.io/centos7/postgresql-12-centos7: unknown: Tag latest was deleted or has expired. To pull, revive via time machine
Error: initializing source docker://quay.io/centos7/postgresql-12-centos7:latest: reading manifest latest in quay.io/centos7/postgresql-12-centos7: unknown: Tag latest was deleted or has expired. To pull, revive via time machine
Trying to pull quay.io/sclorg/postgresql-12-c8s:latest...
Getting image source signatures
Copying blob 0c2ad7c16e40 done   |
Copying blob 9516588f908c skipped: already exists
Copying blob e9d33304e2e9 done   |
Copying config 1dc9bf4b68 done   |
Writing manifest to image destination
1dc9bf4b68aee4972b5f39a7f2f3797dfd1a895c1a7c1b50c65d7e095aa6bd4b

https://quay.io/repository/centos7/postgresql-12-centos7?tab=tags&tag=latest

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2024
@openshift-ci-robot
Copy link

@rccrdpccl: This pull request explicitly references no jira issue.

In response to this:

Trying to pull quay.io/centos7/postgresql-12-centos7:latest...
WARN[0001] Failed, retrying in 1s ... (1/3). Error: initializing source docker://quay.io/centos7/postgresql-12-centos7:latest: reading manifest latest in quay.io/centos7/postgresql-12-centos7: unknown: Tag latest was deleted or has expired. To pull, revive via time machine
WARN[0003] Failed, retrying in 1s ... (2/3). Error: initializing source docker://quay.io/centos7/postgresql-12-centos7:latest: reading manifest latest in quay.io/centos7/postgresql-12-centos7: unknown: Tag latest was deleted or has expired. To pull, revive via time machine
WARN[0006] Failed, retrying in 1s ... (3/3). Error: initializing source docker://quay.io/centos7/postgresql-12-centos7:latest: reading manifest latest in quay.io/centos7/postgresql-12-centos7: unknown: Tag latest was deleted or has expired. To pull, revive via time machine
Error: initializing source docker://quay.io/centos7/postgresql-12-centos7:latest: reading manifest latest in quay.io/centos7/postgresql-12-centos7: unknown: Tag latest was deleted or has expired. To pull, revive via time machine
Trying to pull quay.io/centos7/postgresql-12-centos7:centos7...
Getting image source signatures
Copying blob 10a095b9183e skipped: already exists
Copying blob 06c7e4737942 skipped: already exists
Copying blob c61d16cfe03e skipped: already exists
Copying config b22b91a965 done   |
Writing manifest to image destination
b22b91a96569c182755b01c5ab342d7194f825984fa293cebfd1b1c8c383252b```
<!--
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

You can refer to [Kubernetes community documentation] on writing good commit messages, which provides good tips and ideas.

Some PRs address specific issues. Please, refer to the [CONTRIBUTING] documentation for more
information on how to link a PR to an existing issue.

It's recommended to take a few extra minutes to provide more information about
how this code was tested. Here are some questions that may be worth answering:

- Should this PR be tested by the reviewer?
- Is this PR relying on CI for an e2e test run?
- Should this PR be tested in a specific environment?
- Any logs, screenshots, etc that can help with the review process?

-->

## List all the issues related to this PR

- [ ] New Feature <!-- new functionality -->
- [ ] Enhancement <!-- refactor, code changes, improvement, that won't add new features -->
- [ ] Bug fix
- [ ] Tests
- [ ] Documentation
- [ ] CI/CD <!-- Notice that changes for Dockerfiles/Jenkinsfiles aren't tested in CI due to a known bug. -->

## What environments does this code impact?

- [ ] Automation (CI, tools, etc)
- [ ] Cloud
- [ ] Operator Managed Deployments
- [x] None

## How was this code tested?

<!-- Please, select one or more if needed: -->

- [ ] assisted-test-infra environment
- [ ] dev-scripts environment
- [ ] Reviewer's test appreciated
- [ ] Waiting for CI to do a full test run
- [ ] Manual (Elaborate on how it was tested)
- [x] No tests needed

## Checklist

- [ ] Title and description added to both, commit and PR.
- [ ] Relevant issues have been associated (see [CONTRIBUTING] guide)
- [ ] This change does not require a documentation update (docstring, `docs`, README, etc)
- [ ] Does this change include unit-tests (note that code changes require unit-tests)

## Reviewers Checklist

- Are the title and description (in both PR and commit) meaningful and clear?
- Is there a bug required (and linked) for this change?
- Should this PR be backported?

[Kubernetes community documentation]: https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#commit-message-guidelines
[CONTRIBUTING]: https://github.com/openshift/assisted-service/blob/master/CONTRIBUTING.md

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rccrdpccl
Copy link
Contributor Author

/cc @carbonin @gamli75 @adriengentil

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 27, 2024
@rccrdpccl
Copy link
Contributor Author

it looks like the latest tag disappeared

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
@danmanor
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.31%. Comparing base (fe16303) to head (22bcbb0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6116      +/-   ##
==========================================
- Coverage   68.32%   68.31%   -0.01%     
==========================================
  Files         242      242              
  Lines       35786    35786              
==========================================
- Hits        24449    24448       -1     
- Misses       9214     9215       +1     
  Partials     2123     2123              
Files Coverage Δ
internal/controller/controllers/images.go 100.00% <100.00%> (ø)
internal/common/common_unitest_db.go 20.34% <0.00%> (ø)
internal/common/testcontainers_db_context.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link

openshift-ci bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin, danmanor, rccrdpccl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [carbonin,danmanor,rccrdpccl]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eifrach
Copy link
Contributor

eifrach commented Mar 27, 2024

maybe we should use centos8 which still has builds
quay.io/sclorg/postgresql-12-c8s:latest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@eifrach
Copy link
Contributor

eifrach commented Mar 27, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@rccrdpccl
Copy link
Contributor Author

/test edge-e2e-ai-operator-ztp-capi

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@rccrdpccl
Copy link
Contributor Author

ztp job won't work until we merge openshift/release#50301

@rccrdpccl
Copy link
Contributor Author

/override edge-e2e-ai-operator-ztp edge-e2e-ai-operator-ztp-capi edge-e2e-ai-operator-disconnected-capi

Copy link

openshift-ci bot commented Mar 27, 2024

@rccrdpccl: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • edge-e2e-ai-operator-disconnected-capi
  • edge-e2e-ai-operator-ztp
  • edge-e2e-ai-operator-ztp-capi

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-agent-compact-ipv4
  • ci/prow/edge-assisted-operator-catalog-publish-verify
  • ci/prow/edge-ci-index
  • ci/prow/edge-e2e-ai-operator-disconnected-capi
  • ci/prow/edge-e2e-ai-operator-ztp
  • ci/prow/edge-e2e-ai-operator-ztp-capi
  • ci/prow/edge-e2e-metal-assisted
  • ci/prow/edge-images
  • ci/prow/edge-lint
  • ci/prow/edge-subsystem-aws
  • ci/prow/edge-subsystem-kubeapi-aws
  • ci/prow/edge-unit-test
  • ci/prow/edge-verify-generated-code
  • ci/prow/images
  • ci/prow/mce-images
  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-images
  • pull-ci-openshift-assisted-service-master-e2e-agent-compact-ipv4
  • pull-ci-openshift-assisted-service-master-edge-assisted-operator-catalog-publish-verify
  • pull-ci-openshift-assisted-service-master-edge-ci-index
  • pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-disconnected-capi
  • pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp
  • pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-capi
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted
  • pull-ci-openshift-assisted-service-master-edge-images
  • pull-ci-openshift-assisted-service-master-edge-lint
  • pull-ci-openshift-assisted-service-master-edge-subsystem-aws
  • pull-ci-openshift-assisted-service-master-edge-subsystem-kubeapi-aws
  • pull-ci-openshift-assisted-service-master-edge-unit-test
  • pull-ci-openshift-assisted-service-master-edge-verify-generated-code
  • pull-ci-openshift-assisted-service-master-mce-images
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override edge-e2e-ai-operator-ztp edge-e2e-ai-operator-ztp-capi edge-e2e-ai-operator-disconnected-capi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rccrdpccl
Copy link
Contributor Author

/override ci/prow/edge-e2e-ai-operator-ztp ci/prow/edge-e2e-ai-operator-ztp-capi ci/prow/edge-e2e-ai-operator-disconnected-capi

Copy link

openshift-ci bot commented Mar 27, 2024

@rccrdpccl: Overrode contexts on behalf of rccrdpccl: ci/prow/edge-e2e-ai-operator-disconnected-capi, ci/prow/edge-e2e-ai-operator-ztp, ci/prow/edge-e2e-ai-operator-ztp-capi

In response to this:

/override ci/prow/edge-e2e-ai-operator-ztp ci/prow/edge-e2e-ai-operator-ztp-capi ci/prow/edge-e2e-ai-operator-disconnected-capi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 451970d into openshift:master Mar 27, 2024
17 checks passed
Copy link

openshift-ci bot commented Mar 27, 2024

@rccrdpccl: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rccrdpccl
Copy link
Contributor Author

/cherry-pick cloud_hotfix_releases

@openshift-cherrypick-robot

@rccrdpccl: new pull request created: #6122

In response to this:

/cherry-pick cloud_hotfix_releases

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rccrdpccl
Copy link
Contributor Author

/cherry-pick release-ocm-2.7

@rccrdpccl
Copy link
Contributor Author

/cherry-pick release-ocm-2.8

@rccrdpccl
Copy link
Contributor Author

/cherry-pick release-ocm-2.9

@rccrdpccl
Copy link
Contributor Author

/cherry-pick release-ocm-2.10

@openshift-cherrypick-robot

@rccrdpccl: #6116 failed to apply on top of branch "release-ocm-2.7":

Applying: NO-ISSUE: rename docker image for postgres 12 as latest tag disappeared
Using index info to reconstruct a base tree...
M	Makefile
M	config/manager/manager.yaml
M	config/manifests/bases/assisted-service-operator.clusterserviceversion.yaml
M	deploy/olm-catalog/manifests/assisted-service-operator.clusterserviceversion.yaml
M	docs/dev/testing.md
M	internal/common/common_unitest_db.go
A	internal/common/testcontainers_db_context.go
M	internal/controller/controllers/images.go
Falling back to patching base and 3-way merge...
Auto-merging internal/controller/controllers/images.go
CONFLICT (content): Merge conflict in internal/controller/controllers/images.go
CONFLICT (modify/delete): internal/common/testcontainers_db_context.go deleted in HEAD and modified in NO-ISSUE: rename docker image for postgres 12 as latest tag disappeared. Version NO-ISSUE: rename docker image for postgres 12 as latest tag disappeared of internal/common/testcontainers_db_context.go left in tree.
Auto-merging internal/common/common_unitest_db.go
CONFLICT (content): Merge conflict in internal/common/common_unitest_db.go
Auto-merging docs/dev/testing.md
Auto-merging deploy/olm-catalog/manifests/assisted-service-operator.clusterserviceversion.yaml
Auto-merging config/manifests/bases/assisted-service-operator.clusterserviceversion.yaml
Auto-merging config/manager/manager.yaml
Auto-merging Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 NO-ISSUE: rename docker image for postgres 12 as latest tag disappeared
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-ocm-2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rccrdpccl
Copy link
Contributor Author

/cherry-pick release-ocm-2.11

@openshift-cherrypick-robot

@rccrdpccl: #6116 failed to apply on top of branch "release-ocm-2.8":

Applying: NO-ISSUE: rename docker image for postgres 12 as latest tag disappeared
Using index info to reconstruct a base tree...
M	Makefile
M	config/manager/manager.yaml
M	config/manifests/bases/assisted-service-operator.clusterserviceversion.yaml
M	deploy/olm-catalog/manifests/assisted-service-operator.clusterserviceversion.yaml
M	docs/dev/testing.md
M	internal/common/common_unitest_db.go
A	internal/common/testcontainers_db_context.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): internal/common/testcontainers_db_context.go deleted in HEAD and modified in NO-ISSUE: rename docker image for postgres 12 as latest tag disappeared. Version NO-ISSUE: rename docker image for postgres 12 as latest tag disappeared of internal/common/testcontainers_db_context.go left in tree.
Auto-merging internal/common/common_unitest_db.go
Auto-merging docs/dev/testing.md
Auto-merging deploy/olm-catalog/manifests/assisted-service-operator.clusterserviceversion.yaml
Auto-merging config/manifests/bases/assisted-service-operator.clusterserviceversion.yaml
Auto-merging config/manager/manager.yaml
Auto-merging Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 NO-ISSUE: rename docker image for postgres 12 as latest tag disappeared
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-ocm-2.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@rccrdpccl: #6116 failed to apply on top of branch "release-ocm-2.9":

Applying: NO-ISSUE: rename docker image for postgres 12 as latest tag disappeared
Using index info to reconstruct a base tree...
M	Makefile
M	config/manager/manager.yaml
M	config/manifests/bases/assisted-service-operator.clusterserviceversion.yaml
M	deploy/olm-catalog/manifests/assisted-service-operator.clusterserviceversion.yaml
M	internal/common/common_unitest_db.go
A	internal/common/testcontainers_db_context.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): internal/common/testcontainers_db_context.go deleted in HEAD and modified in NO-ISSUE: rename docker image for postgres 12 as latest tag disappeared. Version NO-ISSUE: rename docker image for postgres 12 as latest tag disappeared of internal/common/testcontainers_db_context.go left in tree.
Auto-merging internal/common/common_unitest_db.go
Auto-merging deploy/olm-catalog/manifests/assisted-service-operator.clusterserviceversion.yaml
Auto-merging config/manifests/bases/assisted-service-operator.clusterserviceversion.yaml
Auto-merging config/manager/manager.yaml
Auto-merging Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 NO-ISSUE: rename docker image for postgres 12 as latest tag disappeared
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-ocm-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@rccrdpccl: #6116 failed to apply on top of branch "release-ocm-2.10":

Applying: NO-ISSUE: rename docker image for postgres 12 as latest tag disappeared
Using index info to reconstruct a base tree...
M	Makefile
M	config/manager/manager.yaml
M	config/manifests/bases/assisted-service-operator.clusterserviceversion.yaml
M	deploy/olm-catalog/manifests/assisted-service-operator.clusterserviceversion.yaml
M	internal/common/common_unitest_db.go
A	internal/common/testcontainers_db_context.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): internal/common/testcontainers_db_context.go deleted in HEAD and modified in NO-ISSUE: rename docker image for postgres 12 as latest tag disappeared. Version NO-ISSUE: rename docker image for postgres 12 as latest tag disappeared of internal/common/testcontainers_db_context.go left in tree.
Auto-merging internal/common/common_unitest_db.go
Auto-merging deploy/olm-catalog/manifests/assisted-service-operator.clusterserviceversion.yaml
Auto-merging config/manifests/bases/assisted-service-operator.clusterserviceversion.yaml
Auto-merging config/manager/manager.yaml
Auto-merging Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 NO-ISSUE: rename docker image for postgres 12 as latest tag disappeared
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-ocm-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@rccrdpccl: new pull request could not be created: failed to create pull request against openshift/assisted-service#release-ocm-2.11 from head openshift-cherrypick-robot:cherry-pick-6116-to-release-ocm-2.11: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-ocm-2.11 and openshift-cherrypick-robot:cherry-pick-6116-to-release-ocm-2.11"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-ocm-2.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants