Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2019128: Merge changes from upstream tag v1.7.0 into master #5

Merged
merged 54 commits into from
Nov 5, 2021
Merged

Bug 2019128: Merge changes from upstream tag v1.7.0 into master #5

merged 54 commits into from
Nov 5, 2021

Conversation

bertinatto
Copy link
Member

andyzhangx and others added 30 commits September 10, 2021 17:14
@andyzhangx
Update linux.json
6ce7248
@andyzhangx
test: remove deprecated test configs
7d64d9c
@andyzhangx
Merge pull request kubernetes-sigs#794 from kubernetes-sigs/remove-de…
d43eca5 
…precated-test-configs

test: remove deprecated test configs
@andyzhangx
test: enable smb fsGroup external test
3be785f
@andyzhangx
Create external.json
26c9792
@andyzhangx
chore: add logging of volumeMountGroup setting
b03ccdb
@andyzhangx
test: remove gid setting in default storage class
451d577
@andyzhangx
test: disable 4 smb fsGroup tests
e901321
@andyzhangx
Merge pull request kubernetes-sigs#795 from kubernetes-sigs/smb-fsgroup
6d72f46 
test: enable smb fsGroup external test
@andyzhangx
test: run v1.22 external test
0c9409e
@andyzhangx
Merge pull request kubernetes-sigs#796 from kubernetes-sigs/external-…
c5873ff 
…1.22

test: run v1.22 external test
@andyzhangx
feat: ReadWriteOncePod support
c4ca372
@andyzhangx
test: disable one sanity test
b3b607c
@andyzhangx
Merge pull request kubernetes-sigs#797 from kubernetes-sigs/ReadWrite…
5a06e7c 
…OncePod

feat: ReadWriteOncePod support
@andyzhangx
cleanup: remove useless user-agent-suffix
c759d4a
@andyzhangx
feat: upgrade snapshot CRD to v4.2.1
87947c2
@k8s-ci-robot
Merge pull request kubernetes-sigs#798 from kubernetes-sigs/upgrade-s…
26f91f1 
…napshot-crd-v4.2.1

feat: upgrade snapshot CRD to v4.2.1
@andyzhangx
feat: enable fsGroup for nfs
8bc3710 
fix: set uid, gid for nfs mount

use os.chmod

remove one logging

remove VOLUME_MOUNT_GROUP cap

fix: SetVolumeOwnership

always update fsgroup

set volume ownership in NodePublishVolume

set fsGid

set gid in NodeStageVolume

only set ownership in NodeStageVolume

refine

fix test panic

disable fsGroup test
@andyzhangx
Merge pull request kubernetes-sigs#759 from kubernetes-sigs/enable-nf…
e3e7952 
…s-fsGroup-test

feat: enable fsGroup for nfs
@andyzhangx
chore: refine ProxyMounter interface
bbcac49
@andyzhangx
Merge pull request kubernetes-sigs#799 from kubernetes-sigs/ProxyMoun…
d0bcaf5 
…ter-refine

chore: refine ProxyMounter interface
@andyzhangx
feat: add ReadWriteOncePod cap
1803c25
@andyzhangx
fix: libssl1.1 VULNERABILITY
5235a66
@andyzhangx
Merge pull request kubernetes-sigs#800 from kubernetes-sigs/ReadWrite…
d160d62 
…OncePod-cap

feat: add ReadWriteOncePod cap
@andyzhangx
Merge pull request kubernetes-sigs#801 from kubernetes-sigs/fix-libss…
dd9bb39 
…l-security

fix: libssl1.1 vulnerability
@andyzhangx
test: add trivy Vulnerability scanning test
1eb25c0
@andyzhangx
Merge pull request kubernetes-sigs#803 from kubernetes-sigs/trivy
f11a816 
test: add trivy vulnerability scanning test
@cyril-corbon
feat: add affinity to charts
47a7610
@andyzhangx
feat: set allowBlobPublicAccess as false by default
06b7e5b
@andyzhangx
Update install-driver-on-aks.md
3a0b665
@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2021
@bertinatto bertinatto changed the title Merge changes from upstream tag v1.7.0 into master Bug 2019128: Merge changes from upstream tag v1.7.0 into master Nov 3, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Nov 3, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2021

@bertinatto: This pull request references Bugzilla bug 2019128, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2019128: Merge changes from upstream tag v1.7.0 into master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 3, 2021
@bertinatto
Copy link
Member Author

/retest

@jsafrane
Copy link

jsafrane commented Nov 3, 2021

Looks good, but why the unit test fail? I see PASS everywhere, am I blind?
/retest

@bertinatto
Copy link
Member Author

/test all

@bertinatto
Copy link
Member Author

/test e2e-azure-file-csi

@bertinatto
Copy link
Member Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Nov 4, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2021

@bertinatto: This pull request references Bugzilla bug 2019128, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 4, 2021
@bertinatto
Copy link
Member Author

/test all
to make sure unit tests won't fail

@bertinatto
Copy link
Member Author

/retest-required

@bertinatto
Copy link
Member Author

/test all

@bertinatto
Copy link
Member Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Nov 5, 2021 •
edited

@bertinatto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-file-csi 2a6d238 link false /test e2e-azure-file-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bertinatto
Copy link
Member Author

/test unit

@dobsonj
Copy link
Member

dobsonj commented Nov 5, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2021
@openshift-merge-robot openshift-merge-robot merged commit a36300f into openshift:master Nov 5, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 5, 2021

@bertinatto: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2019128 has not been moved to the MODIFIED state.

In response to this:

Bug 2019128: Merge changes from upstream tag v1.7.0 into master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobsonj dobsonj Awaiting requested review from dobsonj

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@dobsonj dobsonj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bertinatto @jsafrane @dobsonj @openshift-merge-robot @andyzhangx @k8s-ci-robot @cyril-corbon