STOR-1586: Merge v1.29.3

[gnufied]

This PR was created using git merge v1.29.3 , since @RomanBednar previously rebased against v1.29.2. I still ran in a one line conflict in go.mod file, but that was it.

Alternative is to to use git merge -s ours and while cherry-picking certain commits, I am not sure I was getting some unexpected conflicts.

Fixes https://issues.redhat.com/browse/STOR-1586

[openshift-ci-robot]

@gnufied: This pull request references STOR-1586 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR was created using git merge v1.29.3 , since @RomanBednar previously rebased against v1.29.2. I still ran in a one line conflict in go.mod file, but that was it.

Alternative is to to use git merge -s ours and while cherry-picking certain commits, I am not sure I was getting some unexpected conflicts.

Fixes https://issues.redhat.com/browse/STOR-1586

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gnufied]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gnufied]

/retest

[openshift-ci]

@gnufied: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-file-nfs-csi	d5f5c77	link	true	/test e2e-azure-file-nfs-csi
ci/prow/e2e-azure-file-csi	d5f5c77	link	true	/test e2e-azure-file-csi
ci/prow/images	d5f5c77	link	true	/test images
ci/prow/e2e-azure-file-csi-extended	d5f5c77	link	false	/test e2e-azure-file-csi-extended
ci/prow/e2e-azure-ovn-upgrade	d5f5c77	link	true	/test e2e-azure-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[gnufied]

Hmm, the build is getting killed:

[1/2] STEP 5/5: RUN make azurefile ARCH=$(go env GOARCH) && cp _output/$(go env GOARCH)/azurefileplugin .
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -a -ldflags "-X sigs.k8s.io/azurefile-csi-driver/pkg/azurefile.driverVersion=v1.29.3 -X sigs.k8s.io/azurefile-csi-driver/pkg/azurefile.gitCommit=8703cfa272b38a318040659654dab4a928e4f72c -X sigs.k8s.io/azurefile-csi-driver/pkg/azurefile.buildDate=2024-01-23T21:33:50Z -s -w -extldflags '-static'" -mod vendor -o _output/amd64/azurefileplugin ./pkg/azurefileplugin
github.com/Azure/azure-sdk-for-go/services/network/mgmt/2022-07-01/network: /usr/lib/golang/pkg/tool/linux_amd64/compile: signal: killed
make: *** [Makefile:131: azurefile] Error 1
error: build error: building at STEP "RUN make azurefile ARCH=$(go env GOARCH) && cp _output/$(go env GOARCH)/azurefileplugin .": while running runtime: exit status 2
�[36mINFO�[0m[2024-01-23T21:35:14Z] Ran for 5m25s                                
�[31mERRO�[0m[2024-01-23T21:35:14Z] Some steps failed:      

afaict, it is not failing as such. Just getting killed. Investigating more.

[gnufied]

Closing in favour of #54

/close

[openshift-ci]

@gnufied: Closed this PR.

In response to this:

Closing in favour of #54

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.