Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-32785: Rebase v1.29.5 for OCP 4.16 #64

Merged
merged 66 commits into from
Apr 26, 2024

Conversation

dependabot bot and others added 30 commits January 30, 2024 05:58
Bumps build-image/debian-base from bookworm-v1.0.0 to bookworm-v1.0.1.
…ot/cherry-pick-1681-to-release-1.29

[release-1.29] build(deps): bump build-image/debian-base from bookworm-v1.0.0 to bookworm-v1.0.1 in /pkg/azurefileplugin
…-azcopy-timeout-1.29

[release-1.29] fix: increase volume cloning timeout
…ot/cherry-pick-1698-to-release-1.29

[release-1.29] test: fix goveralls
…ot/cherry-pick-1706-to-release-1.29

[release-1.29] chore: respect RetryAfter in throttling condition
…d-panic-1.29

[release-1.29] fix: panic when controller does not have cloud config
test: fix mock

chore: fix gofmt

test: fix suite test

test: add snapshot test
chore: update cloud provider
…napshot-throttling-1.29

[release-1.29] fix: reduce getFileShare calls during CreateSnapshot and match tags issue in account search logic
…hd-disk-test2

[release-1.29] test: remove vhd disk test
Signed-off-by: Jose Luis Pedrosa <jlpedrosa@gmail.com>
…ot/cherry-pick-1729-to-release-1.29

[release-1.29] fix: ensure azure cloud config could be loaded from secret
…ot/cherry-pick-1723-to-release-1.29

[release-1.29] feat: allow multiple subnets in updating service endpoints
…ot/cherry-pick-1745-to-release-1.29

[release-1.29] fix: nfs protocol does not support standard account
…ot/cherry-pick-1750-to-release-1.29

[release-1.29] test: ignore azcopy CVE-2024-24786
…azcopy-10.23.0-1.29

[release-1.29] feat: upgrade azcopy version to 10.23.0 for volume clone feature
…ot/cherry-pick-1777-to-release-1.29

[release-1.29] fix: strip service account token
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 25, 2024
@openshift-ci-robot
Copy link

@RomanBednar: This pull request references Jira Issue OCPBUGS-32785, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Diff to upstream v1.29.5:
kubernetes-sigs/azurefile-csi-driver@v1.29.5...RomanBednar:azure-file-csi-driver:rebase-v1.29.5

Notable changes:

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from dobsonj and tsmetana April 25, 2024 12:12
Copy link

openshift-ci bot commented Apr 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
Can be dropped if upstream adds this replace to go.mod:

k8s.io/endpointslice => k8s.io/endpointslice v0.29.0

Reported upstream: kubernetes-sigs#2008

Commit fixes verify-deps check which was failing with:

go: k8s.io/endpointslice@v0.0.0: invalid version: unknown revision v0.0.0
ERROR: go list -mod=readonly -m all failed with the message listed above.
Cachito used in ART builds will fail to resolve dependencies offline.
Typically, a pinned version is missing in go.mod, e.g.:
    replace k8s.io/foo => k8s.io/foo v0.26.0
@RomanBednar
Copy link
Author

/retest-required

@jsafrane
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
@jsafrane
Copy link

/retest-required

1 similar comment
@jsafrane
Copy link

/retest-required

@RomanBednar RomanBednar changed the base branch from master to release-4.15 April 26, 2024 11:49
@RomanBednar RomanBednar changed the base branch from release-4.15 to master April 26, 2024 11:50
@RomanBednar
Copy link
Author

/retest-required

@RomanBednar
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 26, 2024
@openshift-ci-robot
Copy link

@RomanBednar: This pull request references Jira Issue OCPBUGS-32785, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cc22aa4 and 2 for PR HEAD 461f062 in total

Copy link

openshift-ci bot commented Apr 26, 2024

@RomanBednar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-commits 461f062 link true /test verify-commits
ci/prow/unit 461f062 link true /test unit
ci/prow/e2e-azure-ovn-upgrade 461f062 link true /test e2e-azure-ovn-upgrade
ci/prow/security 461f062 link false /test security
ci/prow/images 461f062 link true /test images
ci/prow/e2e-azure-file-nfs-csi 461f062 link true /test e2e-azure-file-nfs-csi
ci/prow/e2e-azure-file-csi-extended 461f062 link false /test e2e-azure-file-csi-extended
ci/prow/verify-deps 461f062 link true /test verify-deps
ci/prow/e2e-azure-file-csi 461f062 link true /test e2e-azure-file-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5ceb190 into openshift:master Apr 26, 2024
9 of 10 checks passed
@openshift-ci-robot
Copy link

@RomanBednar: Jira Issue OCPBUGS-32785: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-32785 has not been moved to the MODIFIED state.

In response to this:

Diff to upstream v1.29.5:
kubernetes-sigs/azurefile-csi-driver@v1.29.5...RomanBednar:azure-file-csi-driver:rebase-v1.29.5

Notable changes:

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sdodson
Copy link
Member

sdodson commented Apr 26, 2024

/jira refresh

@openshift-ci-robot
Copy link

@sdodson: Jira Issue OCPBUGS-32785: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32785 has been moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-azure-file-csi-driver-container-v4.16.0-202404291018.p0.g5ceb190.assembly.stream.el9 for distgit azure-file-csi-driver.
All builds following this will include this PR.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.16.0-0.nightly-2024-04-29-154406

@openshift-merge-robot
Copy link

Fix included in accepted release 4.16.0-0.nightly-2024-05-04-214435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet