OCPBUGS-33039: Rebase v1.29.5 for OCP 4.14

[RomanBednar]

Diff to upstream v1.29.5:
kubernetes-sigs/azurefile-csi-driver@v1.29.5...RomanBednar:azure-file-csi-driver:rebase-v1.29.5-ocp4.14

Notable changes:

• [release-1.29] feat: support workload identity setting in static PV mount kubernetes-sigs/azurefile-csi-driver#1647
• [release-1.29] fix: workload identity did not work kubernetes-sigs/azurefile-csi-driver#1785

@openshift/storage

[RomanBednar]

/override ci/prow/verify-commits

[openshift-ci]

@RomanBednar: Overrode contexts on behalf of RomanBednar: ci/prow/verify-commits

In response to this:

/override ci/prow/verify-commits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@RomanBednar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-commits	fe6e8ae	link	true	/test verify-commits

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jsafrane]

/lgtm

[jsafrane]

/label cherry-pick-approved

[openshift-ci]

@jsafrane: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[duanwei33]

/hold
Seems we need additional WA for this. See https://issues.redhat.com/browse/OCPBUGS-32785?focusedId=24644922&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-24644922

[duanwei33]

/label cherry-pick-approved

[duanwei33]

pre-merge verified with this open PR and openshift/azure-file-csi-driver-operator#104:

build 4.14.0-0.ci,#66,openshift/azure-file-csi-driver-operator#104

Followed https://github.com/kubernetes-sigs/azurefile-csi-driver/blob/master/docs/workload-identity-static-pv-mount.md to test static provision with PV, the pod with azure file volume gets running:

$ oc get pod -o wide
NAME                      READY   STATUS    RESTARTS   AGE     IP           NODE                                    NOMINATED NODE   READINESS GATES
statefulset-azurefile-0   1/1     Running   0          2m16s   10.130.2.6   wduan-e414-s2lvp-worker-eastus2-xxxvc   <none>           <none>

$ oc rsh statefulset-azurefile-0 
$ df -h | grep azure
//wduantestshare.file.core.windows.net/wduantest  100T  192K  100T   1% /mnt/azurefile
$ touch /mnt/azurefile/0507
$ ls /mnt/azurefile
0507  outfile  test

$ oc get pv pv-azurefile -o yaml | yq .spec.csi
driver: file.csi.azure.com
$ oc get pv pv-azurefile -o yaml | yq .spec.csi
driver: file.csi.azure.com
volumeAttributes:
  clientID: 1046015d-5b40-44ec-b7a9-448b31dedc15
  resourcegroup: wduan-share
  shareName: wduantest
  storageaccount: wduantestshare
volumeHandle: wduantestshare-wduantest

In the log we see the service account token is used to get the account key during NodePublishVolume:

I0507 01:07:54.249153       1 utils.go:77] GRPC call: /csi.v1.Node/NodeStageVolume
I0507 01:07:54.249175       1 utils.go:78] GRPC request: {"staging_target_path":"/var/lib/kubelet/plugins/kubernetes.io/csi/file.csi.azure.com/b1f27dbe8d29793b2f84c2e68a46e4479d99c7241549802a00f8902b5239c22b/globalmount","volume_capability":{"AccessType":{"Mount":{"mount_flags":["dir_mode=0777","file_mode=0777","uid=0","gid=0","mfsymlinks","cache=strict","nosharesock"],"volume_mount_group":"1000640000"}},"access_mode":{"mode":5}},"volume_context":{"clientID":"1046015d-5b40-44ec-b7a9-448b31dedc15","resourcegroup":"wduan-share","shareName":"wduantest","storageaccount":"wduantestshare"},"volume_id":"wduantestshare-wduantest"}
I0507 01:07:54.249463       1 nodeserver.go:173] Skip NodeStageVolume for volume(wduantestshare-wduantest) since clientID 1046015d-5b40-44ec-b7a9-448b31dedc15 is provided but service account token is empty


......
I0507 01:07:54.275187       1 utils.go:77] GRPC call: /csi.v1.Node/NodePublishVolume
I0507 01:07:54.275669       1 azurefile.go:799] clientID(1046015d-5b40-44ec-b7a9-448b31dedc15) is specified, use service account token to get account key

[duanwei33]

/label qe-approved
/label cherry-pick-approved

[openshift-ci-robot]

@RomanBednar: This pull request references Jira Issue OCPBUGS-33039, which is invalid:

• expected dependent Jira Issue OCPBUGS-33038 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Diff to upstream v1.29.5:
kubernetes-sigs/azurefile-csi-driver@v1.29.5...RomanBednar:azure-file-csi-driver:rebase-v1.29.5-ocp4.14

Notable changes:

• [release-1.29] feat: support workload identity setting in static PV mount kubernetes-sigs/azurefile-csi-driver#1647
• [release-1.29] fix: workload identity did not work kubernetes-sigs/azurefile-csi-driver#1785

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[RomanBednar]

/unhold

[dobsonj]

/jira refresh

[openshift-ci-robot]

@dobsonj: This pull request references Jira Issue OCPBUGS-33039, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.z) matches configured target version for branch (4.14.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-33038 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-33038 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@RomanBednar: Jira Issue OCPBUGS-33039: All pull requests linked via external trackers have merged:

• openshift/azure-file-csi-driver#66
• openshift/azure-file-csi-driver-operator#104

Jira Issue OCPBUGS-33039 has been moved to the MODIFIED state.

In response to this:

Diff to upstream v1.29.5:
kubernetes-sigs/azurefile-csi-driver@v1.29.5...RomanBednar:azure-file-csi-driver:rebase-v1.29.5-ocp4.14

Notable changes:

• [release-1.29] feat: support workload identity setting in static PV mount kubernetes-sigs/azurefile-csi-driver#1647
• [release-1.29] fix: workload identity did not work kubernetes-sigs/azurefile-csi-driver#1785

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-azure-file-csi-driver-container-v4.14.0-202405082212.p0.gf28a507.assembly.stream.el8 for distgit azure-file-csi-driver.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.14.0-0.nightly-2024-05-08-232852