Merge upstream #109
Merged
Merge upstream #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Render BMO deployment
Add capm3 specific configurations in config/ dir
…gmap Add missing ironic bmo configmap in config/default
Fix tls certificate fetch path
Fix kustomization path
Fix tls kustomization path
Fix image name in manager + other small nits
Add missing RBAC for secrets and events
…dware start adding unit tests for Ironic.InspectHardware
Remove old deploy directory
In the HardwareDetails output, our description of a disk's Name field and some of the NIC fields were pretty misleading about what they actually contains.
There doesn't seem to be much point in running all of the lint and unit tests before building the docker image, and it means we have to keep the CI system set up to run extra tools in that job. This patch removes the dependency so `make docker` runs the code generators and then builds the image. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Correct the description of HardwareDetails fields
remove test dependency from docker build
Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Make the BMC access type registration function public so we can add fixture types in tests for the ironic provisioner. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Add a testbmc type so the ironic tests that create hosts can use a test:// URL for the BMC address. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Verify that ValidateManagementAccess() reports an error when the driver needs a bootMACAddress and the host does not have one. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Verify that ValidateManagementAccess() does not report an error when the host has no boot MAC and the BMC does not require one. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Add CreateNodes() method to IronicMock to simulate creating a node. Add a test for ValidateManagementAccess that triggers creating a node and verifies that the host status is updated with the UUID of the new node. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Look at the node struct we're given and register the responses for both UUID and Name, based on which values are filled in. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
This way we can avoid the `go get` hack, and track that dependency with all the other dependencies in the `go.mod` file.
📖 Update deploying document to reflect recent changes
Fix path in install kustomize
Update golang to latest to match version across all repos
…nagement-access start adding unit tests for ironic.ValidateManagementAccess
Re-enable FAST_TRACK and set Online to true when rendering BMH CRs
Add contoller-gen to go.mod
I replaced `Dockerfile` with upstream during conflict resolution.
openshift-ci-robot
added
the
approved
|
/test unit |
1 similar comment
|
/test unit |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, honza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerfilewith upstream contents since we're usingDockerfile.ocpdownstream now