Merge with upstream metal3-io/baremetal-operator #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we end up reconciling the Host again after starting an inspection in Ironic, but before the IntrospectionStatus is available in ironic-inspector, we don't want to attempt to start another inspection. Check if the host is already in the correct state in Ironic before trying to change the state to 'inspecting'. This issue was identified in metal3-io#393, but may not be the cause.
the fix was merged upstream and is in the tripleO package: https://opendev.org/openstack/ironic/commit/7f1f79ac25e270c3585dd23c042a037431b97718
Enable fasttrack for ironic
InvolvedObject APIVersion is expected to be SchemeGroupVersion string
Co-authored-by: Xenwar <anwar.hassen@est.tech>
Restructure kustomization and Add Ironic-Endpoint using Keepalived
The example path is a bit confusing to users, so replace it with an actual working value from real hardware. Also add an example from the ironic documentation at https://docs.openstack.org/ironic/latest/admin/drivers/redfish.html Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Removing the privileged security context to have a more fine-grained control with capabilities. NET_ADMIN set for dnsmasq and httpd (in case the user specifies a low port)
Remove container privileges and add NET_ADMIN capability
Change ironic endpoint keepalived image
Add verify ca
…xample update example URL for redfish driver
There is a typo for DisableCertificateVerification that causes the e2e tests to fail. Signed-off-by: Yolanda Robla <yroblamo@redhat.com>
…en up date PR 140 in baremetal
Add available ProvisioningState , so CAPBM is aware of this state
Add support to reconcile concurrently
Avoid starting inspection twice
This is to comply with CAPI secrets
Look for userData or value in the userdata secret
Add a Pause annotation for pivoting
Update Configuration with Kustomize info
Add --namespace cli argument support for BMO
Remove v1alpha2 CI status badges
Fix make test phony to remove dep-check call
New kustomize config for BMO standalone, needed with kind when ironic…
…variables Default missing variables
Fix Ironic fast-track for local BMO deployment
|
Looks like some of the dependancies @n1r1 added got lost in the Gopk.toml -> go.mod transition. Will fix |
|
Test failures seem related to this sequence of commits:
@honza can you share the secret sauce that allows upstream to build without a vendor directory? |
|
/retest |
|
/refresh |
|
I think to make this work, you'll need to run I assume it probably needs to be an OCP-only thing, since I wouldn't expect upstream to carry milions of lines of vendored code because of a limitation on our CI servers. |
Upstream has moved to a vendorless codebased, however downstream CI still requires it, even after being configured to use go 1.13+ Signed-off-by: Andrew Beekhof <andrew@beekhof.net>
|
/lgtm |
|
@hardys @dhellmann @russellb Could one of you approve please? Thanks! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: beekhof, hardys, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve merge conflicts