Merge upstream 2020-06-17 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes a caller actually needs to know whether we succeeded in changing the provisioning state or if we're just retrying because of a conflict. Mostly it doesn't though, so implement it as a separate method to avoid adding complexity everywhere.
Add reviewers who are not already in the approvers list based on the policy described in metal3-io/metal3-docs#93 dukov also qualifies, but is not yet a member of the org so will be added near the end of the transition Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Add tryChangeNodeProvisionState() method in ironic provisioner
initialize reviewers list
Change-Id: Ic0521a8308a15202ec5ed90fea44fc0f02b6d2de
Golang 1.14 introduces new defaults around modules, namely the -mod flag. If a vendor directory is present, it will be used; if it's not, the new go module system will be used. This will allow us to build this module in a variety of environments without changing our build scripts.
Golang 1.14 introduces some small changes to the semantics of the go.mod file so we are updating it to reflect that (this is done with `go mod tidy`, not by hand.).
Add Dmitry Ukov to reviewers list
Upgrade module to Golang 1.14, and tidy modules
🏃 Add small changes to BMO and Ironic deployment documentation
Go 1.14 introduces some new semantics, this is an auto generated change.
Go 1.14 introduces new defaults that make this unnecessary. If a vendor directory is present, it will be used. If it's absent, the regular go module system will be used.
openshift-ci-robot
added
the
approved
|
/test e2e-metal-ipi |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: honza, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of commits on top of the merge:
-mod=vendorflag from the build commandThis solves the same problem as #76 but it's more elegant. Golang 1.14 introduces new defaults that make the
modflag unnecessary in our scenario (both upstream and downstream).