sync upstream changes 2020-07-29 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhellmann
commented
Jul 29, 2020
dhellmann
commented
- implementation of boot mode API
- OpenShift build variables to ensure the version info is compiled in properly
- dep: cve: bump go-openapi/spec to v0.19.9
- update CRD version to v1 for pruning feature
The existing apiextensions.k8s.io/v1beta1 version is deprecated and will be removed in k8s 1.19. v1 is available from k8s 1.16. Using v1, unknown fields are now pruned by default, which is what we want. Fixes metal3-io#327 Fixes metal3-io#580
Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Reuse the logic for building the address for redfish drivers. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
refactor redfish driver hierarchy
go-openapi/spec v0.19.9 bumps go-openapi/jsonreference to v0.19.4 go-openapi/jsonreference v0.19.4 bumps golang.org/x/text to v0.3.3 golang.org/x/text v0.3.3 mitigates against CVE-2020-14040 https://groups.google.com/g/golang-announce/c/bXVeAmGOqz0?pli=1 Signed-off-by: Honza Pokorny <honza@redhat.com>
dep: cve: bump go-openapi/spec to v0.19.9
metal3-dev-env uses this program to create host resources. In order to let metal3-dev-env change the boot mode for hosts, we need to add an option to pass the value through to the template. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
add -boot-mode argument to make-bm-worker
Switch CRD version to apiextensions.k8s.io/v1
The OpenShift release build environment exposes the SOURCE_GIT_COMMIT and BUILD_VERSION environment variables to reference the right git commit and current build version
Add support for build variables
Default to UEFI everywhere, but allow the user to override that value by setting Spec.BootMode. Implements https://github.com/metal3-io/metal3-docs/blob/master/design/baremetal-operator/explicit-boot-mode.md Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
implement explicit boot mode api field
openshift-ci-robot
added
the
approved
go mod vendor; go mod tidy Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.