Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build broken by openshift/api tag deletion #414

Closed
cgwalters opened this issue Feb 3, 2020 · 7 comments
Closed

build broken by openshift/api tag deletion #414

cgwalters opened this issue Feb 3, 2020 · 7 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@cgwalters
Copy link
Member

We currently pin a now-deleted v3.9.1 tag which was apparently deleted: openshift/api#456

I tried to fix this up but ended up in go mod hell, not quite sure what was going on.

@petr-muller
Copy link
Member

Our automation does not interact with GH tags in any way. I believe I saw a Slack convo about this topic with @smarterclayton involved?

@cgwalters
Copy link
Member Author

Our automation does not interact with GH tags in any way.

The go.mod says:

github.com/openshift/api v3.9.1-0.20190725193935-b7d4eb0fa1e0+incompatible

But that v3.9.1 tag no longer exists:

walters@toolbox ~/s/g/o/ci-tools> make build
go build ./cmd/...
go: github.com/openshift/api@v3.9.1-0.20190725193935-b7d4eb0fa1e0+incompatible: invalid pseudo-version: preceding tag (v3.9.0) not found
make: *** [Makefile:7: build] Error 1
walters@toolbox ~/s/g/o/ci-tools> 

@cgwalters cgwalters reopened this Feb 4, 2020
@stlaz
Copy link
Member

stlaz commented Feb 11, 2020

The issue is about this repository being broken, not the actual automation. You can't build using make build (if you think you can, try running go clean -modcache && make build). I overcame certain problems trying to fix this for you, but eventually got stuck with some ambiguous Azure imports somewhere deep in kube, flipped the table and decided to leave that up to you.

You should also decide whether you want to keep your vendor/ directory as you're not currently using it (at least when building with go 1.13).

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 28, 2020
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 28, 2020
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants