Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: bump controller-runtime #1902

Merged
merged 1 commit into from
Apr 23, 2021
Merged

vendor: bump controller-runtime #1902

merged 1 commit into from
Apr 23, 2021

Conversation

stevekuznetsov
Copy link
Contributor

Signed-off-by: Steve Kuznetsov skuznets@redhat.com

/assign @alvaroaleman

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2021
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2021
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2021
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alvaroaleman,stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@alvaroaleman
Copy link
Contributor

alvaroaleman commented Apr 22, 2021 via email

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2021
@stevekuznetsov
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2021
@openshift-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@stevekuznetsov
Copy link
Contributor Author

WTF GitHub ... this is rebased.

@stevekuznetsov
Copy link
Contributor Author 

$ git log -n 1 upstream/master 
commit 0037bd31f15e948c4cf2dc2aecb5214dafe98d31 (upstream/master, upstream/HEAD)
Merge: 043bed4dd be0726839
Author: OpenShift Merge Robot <openshift-merge-robot@users.noreply.github.com>
Date:   Thu Apr 22 14:51:27 2021 -0400

    Merge pull request #1900 from petr-muller/20210422-test-infra-bump
    
    Bump test-infra to 28747eb818b8
$ git rebase upstream/master 
Current branch skuznets/bump-c-r is up to date.

@stevekuznetsov
vendor: bump controller-runtime
29525b6 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov
Copy link
Contributor Author

Fixed more YAML formatting .sigh.

@stevekuznetsov stevekuznetsov added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 23, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 64cc0c9 into openshift:master Apr 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 23, 2021

@stevekuznetsov: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/breaking-changes 29525b6 link /test breaking-changes

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevekuznetsov
Copy link
Contributor Author

stevekuznetsov commented Apr 23, 2021 •
edited by openshift-ci-robot

Part of DPTP-1822

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@AlexNPavel AlexNPavel Awaiting requested review from AlexNPavel

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@alvaroaleman alvaroaleman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stevekuznetsov @openshift-ci-robot @openshift-bot @alvaroaleman @openshift-merge-robot