Merge pull request #88 from openshift-cloud-team/rebase-bot-master

OCPBUGS-22556,OCPCLOUD-2422: Update to kubernetes v1.29

.github/workflows/dependency-review.yml

@@ -17,11 +17,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Harden Runner
-        uses: step-security/harden-runner@8ca2b8b2ece13480cda6dacd3511b49857a23c09 # v2.5.1
+        uses: step-security/harden-runner@eb238b55efaa70779f274895e782ed17c84f2895 # v2.6.1
         with:
           egress-policy: audit
 
       - name: 'Checkout Repository'
-        uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0
+        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
       - name: 'Dependency Review'
-        uses: actions/dependency-review-action@6c5ccdad469c9f8a2996bfecaec55a631a347034 # v3.1.0
+        uses: actions/dependency-review-action@c74b580d73376b7750d3d2a50bfb8adc2c937507 # v3.1.5

.github/workflows/lint-ci-weekly.yaml

@@ -0,0 +1,31 @@
+name: Code Lint weekly
+
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: '* * * * 5'  
+permissions:
+  contents: read
+
+jobs:
+  Lint:
+    permissions:
+      contents: read  # for actions/checkout to fetch code
+    runs-on: ubuntu-latest
+    steps:
+      - name: Harden Runner
+        uses: step-security/harden-runner@eb238b55efaa70779f274895e782ed17c84f2895 # v2.6.1
+        with:
+          egress-policy: audit
+      - name: Setup Golang
+        uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
+        with:
+          go-version: '>=1.21'
+          check-latest: true
+      - name: Checkout
+        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@3a919529898de77ec3da873e3063ca4b10e7f5cc # v3.7.0
+        with:
+          # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
+          version: latest

.github/workflows/scorecards.yml

@@ -32,17 +32,17 @@ jobs:
 
     steps:
       - name: Harden Runner
-        uses: step-security/harden-runner@8ca2b8b2ece13480cda6dacd3511b49857a23c09 # v2.5.1
+        uses: step-security/harden-runner@eb238b55efaa70779f274895e782ed17c84f2895 # v2.6.1
         with:
           egress-policy: audit
 
       - name: "Checkout code"
-        uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0
+        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
         with:
           persist-credentials: false
 
       - name: "Run analysis"
-        uses: ossf/scorecard-action@08b4669551908b1024bb425080c797723083c031 # v2.2.0
+        uses: ossf/scorecard-action@0864cf19026789058feabb7e87baa5f140aac736 # v2.3.1
         with:
           results_file: results.sarif
           results_format: sarif
@@ -64,7 +64,7 @@ jobs:
       # Upload the results as artifacts (optional). Commenting out will disable uploads of run results in SARIF
       # format to the repository Actions tab.
       - name: "Upload artifact"
-        uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
+        uses: actions/upload-artifact@1eb3cb2b3e0f29609092a73eb033bb759a334595 # v4.1.0
         with:
           name: SARIF file
           path: results.sarif

.github/workflows/update-vendor-license.yml

@@ -37,14 +37,14 @@ jobs:
 
     steps:
     - name: Harden Runner
-      uses: step-security/harden-runner@8ca2b8b2ece13480cda6dacd3511b49857a23c09 # v2.5.1
+      uses: step-security/harden-runner@eb238b55efaa70779f274895e782ed17c84f2895 # v2.6.1
       with:
         egress-policy: audit
 
     - name: Checkout repository
-      uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0
+      uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
     - name: Set up Go 1.x
-      uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0
+      uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
       with:
         go-version: '>=1.20'
         check-latest: true

.golangci.yml

@@ -1,27 +1,26 @@
 run:
   timeout: 30m
-  go: '1.20'
+  go: '1.21'
   tests: true
   skip-dirs:
     - vendor
 linters:
   disable-all: true
   enable:
     - errcheck
+    - gosimple
+    - govet
+    - ineffassign
+    - staticcheck
+    - unused
     - goconst
-    - gofmt
     - goimports
     - revive
     - gosec
-    - gosimple
-    - govet
-    - ineffassign
     - misspell
     - nakedret
-    - staticcheck
     - typecheck
     - unconvert
-    - unused
     - asasalint
     - asciicheck
     - bidichk
@@ -43,3 +42,7 @@ linters-settings:
       - G114
   goimports:
     local-prefixes: sigs.k8s.io/cloud-provider-azure
+  goconst:
+    min-occurrences: 10
+
+

.pipelines/ccm-image.yml

@@ -1,7 +1,7 @@
 steps:
   - task: GoTool@0
     inputs:
-      version: '1.19'
+      version: '1.21.5'
   - bash: |
       git show --stat
       echo $REGISTRY_PASSWORD | docker login $REGISTRY_URL -u $REGISTRY_USERNAME --password-stdin

.pipelines/cnm-image.yml

@@ -1,7 +1,7 @@
 steps:
   - task: GoTool@0
     inputs:
-      version: '1.19'
+      version: '1.21.5'
   - bash: |
       git show --stat
       echo $REGISTRY_PASSWORD | docker login $REGISTRY_URL -u $REGISTRY_USERNAME --password-stdin

.pipelines/run-autoscaling-e2e.yml

@@ -33,7 +33,7 @@ stages:
       steps:
         - task: GoTool@0
           inputs:
-            version: '1.19'
+            version: '1.21.5'
         - bash: |
             CLUSTER_TYPE="autoscaling"
             echo "##vso[task.setvariable variable=CLUSTER_TYPE]${CLUSTER_TYPE}"

.pipelines/run-autoscaling-multipool-e2e.yml

@@ -33,7 +33,7 @@ stages:
       steps:
         - task: GoTool@0
           inputs:
-            version: '1.19'
+            version: '1.21.5'
         - bash: |
             CLUSTER_TYPE="autoscaling-multipool"
             echo "##vso[task.setvariable variable=CLUSTER_TYPE]${CLUSTER_TYPE}"

.pipelines/run-basic-lb-e2e.yml

@@ -36,7 +36,7 @@ stages:
       steps:
         - task: GoTool@0
           inputs:
-            version: '1.19'
+            version: '1.21.5'
         - bash: |
             CLUSTER_TYPE="basic-lb"
             echo "##vso[task.setvariable variable=CLUSTER_TYPE]${CLUSTER_TYPE}"

.pipelines/run-vmas-e2e.yml

@@ -33,7 +33,7 @@ stages:
       steps:
         - task: GoTool@0
           inputs:
-            version: '1.19'
+            version: '1.21.5'
         - bash: |
             CLUSTER_TYPE="vmas"
             echo "##vso[task.setvariable variable=CLUSTER_TYPE]${CLUSTER_TYPE}"

Dockerfile

@@ -14,7 +14,7 @@
 
 # syntax=docker/dockerfile:1
 
-FROM --platform=linux/amd64 golang:1.21-bullseye@sha256:436969571fa091f02d34bf2b9bc8850af7de0527e5bc53c39eeda88bc01c38d3 AS builder
+FROM --platform=linux/amd64 golang:1.21-bullseye@sha256:3b4ac7623c123263662ec6c62ef7b97a1e47b8c9e03de9e631651b293f5b8e41 AS builder
 
 ARG ENABLE_GIT_COMMAND=true
 ARG ARCH=amd64