OCPBUGS-33351,OCPBUGS-22556,OCPCLOUD-2422: Update to kubernetes v1.29

[cloud-team-rebase-bot]

No description provided.

[openshift-ci]

Hi @cloud-team-rebase-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[damdo]

Here we'll need to drop 6067ccd (UPSTREAM: 3887: default to kube-proxy health probes for Service type) as that PR never merged upstream and was instead closed.

Upstream instead decided to allow us to fix this by opting into a feature introduced with a different PR (kubernetes-sigs#4891), which recently merged.

That PR is being brought in by this rebase, but we must opt into it by setting clusterServiceLoadBalancerHealthProbeMode=servicenodeport as it defaults to shared in the Cloud config (in the openshift-config-managed/kube-cloud-config ConfigMap?).

[elmiko]

@damdo are you going to fix this up, or is the card still open?

[damdo]

@elmiko Not sure who owns/owned this rebase for 4.15

[damdo]

/test commitchecker

[openshift-ci]

@damdo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test e2e-azure-ovn
• /test e2e-azure-ovn-upgrade
• /test images
• /test unit
• /test verify

The following commands are available to trigger optional jobs:

• /test verify-git-history

Use /test all to run all jobs.

In response to this:

/test commitchecker

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[damdo]

/test verify-git-history

[damdo]

/test verify-commits

[damdo]

/label rebase/manual

[openshift-ci-robot]

@theobarberbany: This pull request references Jira Issue OCPBUGS-22556, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

This pull request references OCPCLOUD-2422 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[damdo]

@nrb we will want to run the payload tests to exercise and rehearse the upgrade story, considering that's the pain point that the previous health check carry was addressing, and that the newer approach is supposed to take the place of.

Thus launching some
/payload-aggregate periodic-ci-openshift-release-master-ci-4.16-e2e-azure-ovn-upgrade 10

[openshift-ci]

@damdo: trigger 1 job(s) for the /payload-(job|aggregate) command

• periodic-ci-openshift-release-master-ci-4.16-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/db266e30-b564-11ee-8729-0d243ec58145-0

[damdo]

@nrb It looks like all payload upgrades have failed 😐 https://pr-payload-tests.ci.openshift.org/runs/ci/db266e30-b564-11ee-8729-0d243ec58145-0 (see job-run-summary for aggregated we might need to investigate why) cc. @JoelSpeed

[JoelSpeed]

This commit is empty, can we drop it?

[JoelSpeed]

Do we use this, wondering if we need this change?

[nrb]

Looks like it came in from upstream as I was cherry-picking our stuff onto the Makefile.

https://github.com/kubernetes-sigs/cloud-provider-azure/blob/master/Makefile#L390 is where it's defined and https://github.com/kubernetes-sigs/cloud-provider-azure/blob/master/cloudbuild.yaml#L22 is where it's used.

I'd say we should keep it to make future rebases easier, but I'm not overly attached to that idea, either.

[JoelSpeed]

Yeah my point was more, I don't understand why our commit changes this part of the makefile, should it not just be adding the include?

[nrb]

I think I see what I did; will fix.

[nrb]

Fixed.

[damdo]

@nrb Had a chat with @xueqzhan which cleared up the air for us regarding the aggregated payload results.
They all passed but timed out during cleanup (the resource watch takes longer in 4.16), which is independent of this change and is going to be tracked by them separately.

So I think I'm happy with this PR, bare @JoelSpeed comment

[nrb]

This commit is empty, can we drop it?

@JoelSpeed Done.

[JoelSpeed]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@cloud-team-rebase-bot[bot]: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@cloud-team-rebase-bot[bot]: Jira Issue OCPBUGS-22556: All pull requests linked via external trackers have merged:

• openshift/cloud-provider-azure#88

Jira Issue OCPBUGS-22556 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-azure-cloud-controller-manager-container-v4.16.0-202401191549.p0.g4295526.assembly.stream for distgit ose-azure-cloud-controller-manager.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-azure-cloud-node-manager-container-v4.16.0-202401191549.p0.g4295526.assembly.stream for distgit ose-azure-cloud-node-manager.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-01-21-092529

[damdo]

/retitle OCPBUGS-33351,OCPBUGS-22556,OCPCLOUD-2422: Update to kubernetes v1.29

[openshift-ci-robot]

@cloud-team-rebase-bot[bot]: Jira Issue OCPBUGS-33351: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33351 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-22556 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.